Activity
From 06/04/2022 to 06/10/2022
06/10/2022
-
09:48 PM Revision 52da90ac (git): Make method id explicit in rb_exec_recursive_outer
- Previously, because opt_aref and opt_aset don't push a frame, when they
would call rb_hash to determine the hash valu... -
-
09:41 PM Revision 44b3daa0 (git): [ruby/fileutils] Enhanced RDoc (https://github.com/ruby/fileutils/pull/83)
- Treats ::chmod_R and ::chown.
https://github.com/ruby/fileutils/commit/df4ac84bef -
09:11 PM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
- I 100% agree. I think we should aim to get it into a preview and ideally get another preview release. If people have ...
-
09:44 AM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
- schneems (Richard Schneeman) wrote in #note-19:
> It's maybe worth asking as well, how confident is Ruby core that... -
08:47 PM Revision fc484be5 (git): Add assertion for embedded to embedded ivar copy
- 05:52 PM Revision 9ed9cc98 (git): Add tests for a variety of string-subclass operations (#5999)
- This way YJIT has to match CRuby for each of them.
Remove unused string_p() Rust function - 04:29 PM Revision 46333f59 (git): * 2022-06-11 [ci skip]
- 04:29 PM Revision e777ac91 (git): Don't return a value from jit_guard_known_klass. We never return anything but true at this point and we don't usually check the returned value. (#6000)
-
03:46 PM Bug #18768: Inconsistent behavior of IO, StringIO and String each_line methods when return paragraph and chomp: true passed
- mame (Yusuke Endoh) wrote in #note-8:
> @jeremyevans0 Thank you for your explanation, I understand. The keyword name... -
09:39 AM Bug #18768: Inconsistent behavior of IO, StringIO and String each_line methods when return paragraph and chomp: true passed
- @jeremyevans0 Thank you for your explanation, I understand. The keyword name "chomp" might be a bit confusing.
-
02:56 PM Revision 1e528e8c (git): small fix on `setup_debug_log()`
- * print `ruby_debug_log_mode` at first.
* show filters when `ruby_debug_log_mode` is not "disabled". - 02:12 PM Revision c54f4264 (git): Remove duplicated rb_yjit_get_stats (#5997)
- `rb_yjit_get_stats` is defined twice in yjit.c, it only needs to be
defined once. -
12:11 PM Feature #11164: Garbage collector in Ruby 2.2 provokes unexpected CoW
- That seems to be exactly what https://github.com/ko1/nakayoshi_fork solves anyway.
-
- This ticket raised GC's efficiency issue. As far as I read, it was not a regression. I consider that this is not a bu...
-
10:58 AM Bug #18771 (Closed): IO.foreach/.readlines ignores the 4th positional argument
- Applied in changeset commit:git|27eb36596a65d6bca44b4420ca6526175bf1b431.
----------
Stop ignoring 4th positional ar... -
- Maybe because of time, I cannot understand what is a problem. What do you mean "ignored"?
A bundled gem has been u... -
- I believe this is not a bug. The current YARV compiler is a product of trial and error, and we know that sometimes it...
-
- According to the OP, there is the same issue in Ruby 3.0 and the same fix works for Ruby 3.0. Continue to discuss it ...
-
- I found two bug reports in other projects that have a similar stack trace:
https://github.com/lastpass/lastpass-cl... -
- I tried the script on Windows 11 / WSL2 Ubuntu 22.04, but couldn't repro the issue. I guess WSL2 solved the issue. Pl...
-
- For the third and forth examples, you can use `BOM|UTF-8` encoding.
```
$ ruby -e 'p File.read("utf-8-with-bom-fi... -
- Does this still reproduce?
-
- I believe this is a spec of Windows. Ruby's IO interface is based on C's stdio, and I confirmed that `fwrite("Hello\n...
-
02:24 AM Feature #16495: Inconsistent quotes in error messages
- The more pervasive Markdown becomes, the more annoying this quoting style becomes.
-
01:10 AM Revision e75cb61d (git): Fix nested bmethod TracePoint and memory leak
- df317151a5b4e0c5a30fcc321a9dc6abad63f7ed removed the code to free
rb_hook_list_t, so repeated targeting of the same b...
06/09/2022
-
11:17 PM Revision cedc36ec (git): Remove a leftover require
- I thought about using it in 2931957d6ff16b5c095f6e8095384c98130133ad
once and then ended up not using it. - 09:59 PM Revision e69e47f8 (git): Fix exit locations test (#5995)
- I originally added the check for
RubyVM::YJIT.trace_exit_locations_enabled? to fix errors when these
tests run withou... -
- Treats ::chmod; adds Pathname usage to ::install.
https://github.com/ruby/fileutils/commit/9db4cb129c -
07:13 PM Feature #18183: make SecureRandom.choose public
- In case we really can't agree on the name.
I reimplement the functionality as an independent class on a GitHub's G... -
- Thanks you for the patch. I am not the best to review the C code but I have looked at it. Notably the test seems to i...
-
01:59 PM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
- A draft of `SyntaxError#detailed_message`.
https://github.com/nobu/ruby/tree/syntax_error-detail - 06:40 PM Revision adcfd696 (git): [DOC] Fix markup for `String` (#5984)
- * Add missing space for `String#start_with?`.
* Add missing pluses for `String#tr` and
`Methods for Converting to N... - 04:59 PM Revision 473ee328 (git): Add ability to trace exit locations in yjit (#5970)
- When running with `--yjit-stats` turned on, yjit can inform the user
what the most common exits are. While this is us... -
04:46 PM Bug #17810 (Closed): addr2line.c: Some symbol names missing in C backtrace with Clang/LLVM
- Applied in changeset commit:git|940c8b093de1d903b67b7d80cc33f698a5debf1c.
----------
Skip `NULL` values from `dladdr... -
- Applied in changeset commit:git|9d927204e7b86eb00bfd07a060a6383139edf741.
----------
error.c: Let Exception#inspect ... - 03:22 PM Revision 1b5828f9 (git): * 2022-06-10 [ci skip]
-
- Fixes [Bug #18771]
-
- mame (Yusuke Endoh) wrote in #note-6:
> I have no strong opinion about this issue and am never against Jeremy's chan... -
- I have no strong opinion about this issue and am never against Jeremy's change, but I'm just curious. I thought that ...
-
- This looks good to me and I think it's a good addition.
In the past, I've referred to this operation as "URI.encode_... -
- Proposed implementation: https://github.com/ruby/cgi/pull/26
-
- I forgot to mention that we'd need the decode method as well.
-
- ### Context
There are two fairly similar encoding methods that are often confused.
`application/x-www-form-url... -
- Fixes [Bug #17810]
-
10:33 AM Bug #18729 (Open): Method#owner and UnboundMethod#owner are incorrect after using Module#public/protected/private
- mame (Yusuke Endoh) wrote in #note-17:
> @matz changed his mind: https://bugs.ruby-lang.org/issues/18435#note-11
> ... -
- mame (Yusuke Endoh) wrote in #note-6:
> @ko1 proposed the following, and @matz approved this at the dev meeting.
> ... -
- I believe the only way that makes sense here is to remove "ZSUPER methods" altogether.
Other Ruby implementations do... -
- `timeout 0.3.0` broke our test suite because we have some
tests that stubs `Process.clock_gettime` making it return
a... -
- I believe this is not a bug. I don't think the current behavior is very useful, but I don't think it is so problemati...
-
09:28 AM Bug #18643 (Closed): test-bundler failed on ruby_3_1 CI
- This issue already resolved.
-
- Fixed at commit:bda4d91f0599a8e2d278bc13660a5576d4ced353
-
- The chart (https://www.unicode.org/charts/case) that is currently
referred seems to be wrong.
Also, use the "latest"... -
- @xtkoba I'm not familiar with DWARF. Could you show a reference to justify your change, for example the section of th...
-
09:14 AM Feature #16597: missing poll()
- Is there some change of getting the poll() semantic available in ruby?
-
- @xtkoba What platform did you use to test your patch?
-
- @xtkoba Can you give me an example of a specific environment where this would be an actual problem? I can't verify this.
-
- This ticket was created to confirm whether this is a bug of Ruby (https://github.com/ruby/fiddle/issues/72#issuecomme...
-
- I could reproduce it with clang 12.
Could you explaiun the rationale of `traces[i] = (void *)(((uintptr_t)traces[i... -
- I couldn't reproduce the issue on AWS Graviton2 instance. Could you elaborate how to reproduce the issue?
```
$ u... -
07:24 AM Feature #18821: Expose Pattern Matching interfaces in core classes
- I'll write a bit more on this later in longer form, but I do believe we have a very interesting and amusingly very Ru...
-
- I have opened one PR against CSV: https://github.com/ruby/ruby/pull/5994
I have noted the potential precedent this... -
- matz (Yukihiro Matsumoto) wrote in #note-2:
> I agree with part of the proposal. Set and OpenStruct do not have orde... -
03:30 AM Feature #18821: Expose Pattern Matching interfaces in core classes
- I agree with part of the proposal. Set and OpenStruct do not have order of elements, so it's not suitable for convert...
-
- I think this issue can be easily worked around by using `IO#set_encoding_by_bom` which was introduced by #15210.
`... -
- I assume that "additional calculation" means the code `if (start > 0) { start--; continue; }`, but the "additional ca...
-
-
- I asked @nobu about the current status of this ticket, and he said "the current behavior is definitely a bug, but I a...
-
- We could fix it, but removing files in the directory recursively is
tedious in C and --mjit-debug is not a concern fo... -
- ```
compiling ../debug.c
../debug.c:452:1: error: conflicting types for 'ruby_debug_log_filter'
ruby_debug_log_filter...
06/08/2022
-
- https://github.com/ruby/fileutils/commit/b9d5a79e38
-
07:23 PM Bug #18820: on aarch64/Android/Termux/Ubuntu jammy server, ALL versions before Ruby 3.1.x don't compile!
- the 2.5.x build-failure was due to all warnings being converted to errors, and some screwy casting ( between types )....
-
05:00 AM Bug #18820 (Closed): on aarch64/Android/Termux/Ubuntu jammy server, ALL versions before Ruby 3.1.x don't compile!
-
- btw, this is a frustrating bug-reporting system to report a bug in?
so if I've reported it in the wrong place,
just... -
- I'm planning to redesign the MJIT worker pipeline, and this allows you to simplify the implementation and let it run ...
-
- `RUBY_DEBUG_LOG_FILTER` specified only function names but this
patch also check file names for each log events.
If yo... -
04:09 PM Revision 8d573363 (git): Fix major GC thrashing
- Only growth heaps are allowed to start major GCs. Before this patch,
growth heaps are defined as size pools that free... -
- Fixed by commit:c5475f42694eff35465c3332e0182c0611ca5918 (I messed up the bug reference in the commit message).
-
-
-
-
- I added a pull request for this patch and the patches for #18121 and #18081: https://github.com/ruby/ruby/pull/4957
-
- irb pull request for this issue: https://github.com/ruby/irb/pull/353
- 03:26 PM Revision 08a6ec34 (git): * 2022-06-09 [ci skip]
-
- force_major_gc_count was not defined when USE_RVARGC=0.
-
- force_major_gc_count is the number of times the size pool forced major
GC to run. -
- Adds a note about file tree examples.
https://github.com/ruby/fileutils/commit/65ac65067a - 08:49 AM Revision 6a6531d3 (git): Update "Reporting Issues" link in the README
- This link is broken.
-
08:25 AM Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
- I opened a PR with this patch. Happy to try fixing it a different way but this at least stops the crash. https://gith...
-
- I opened a PR with this patch: https://github.com/ruby/ruby/pull/5991
-
- I opened a pull request with this patch: https://github.com/ruby/ruby/pull/5992
-
- I think it's a good idea to create a pull request in each repository.
https://github.com/ruby/set
https://github.... -
- ## Problem Statement
Pattern matching is an exceptionally powerful feature in modern versions of Ruby, but it has ... -
- I wanted to point out there's --output=all.
-
- I'm unsure the precise procedure to reproduce the issue, but I couldn't repro it in any way. Maybe fixed by #18191? F...
-
-
- Thanks for your investigating and patches.
This looks like a great improvement.
Test frameworks should probably...
06/07/2022
-
08:19 PM Bug #18170: Exception#inspect should not include newlines
- Sorry that the `#inspect` call actually came from the `ruby/debug`'s [own patch](https://github.com/ruby/debug/blob/m...
-
- Can you show where a change to `#inspect` will impact this code?
-
- I think this change will affect many users' tests because test frameworks generally use exceptions for assertion mess...
-
- rb_imemo_new is defined again later in the file.
-
06:07 PM Feature #18819 (Closed): Moving Strings between size pools
- [Github PR](https://github.com/ruby/ruby/pull/5986)
## Motivation
Using GC Compaction we can move objects aroun... -
- 03:21 PM Revision bdc6e991 (git): * 2022-06-08 [ci skip]
- 03:20 PM Revision 1598c945 (git): Add special-case code for the String unary plus operator (#5982)
-
02:23 PM Bug #18816: Ractor segfaulting MacOS 12.4 (aarch64 / M1 processor)
- I've tried to isolate the problem with a few attempts:
First guess was that something GC related (cleaning up some... -
02:17 PM Bug #18816: Ractor segfaulting MacOS 12.4 (aarch64 / M1 processor)
- I get the same segfault, but not as consistent as Gabriel. I had to first do a normal request in the browser before r...
-
02:18 PM Revision deff9e26 (git): [rubygems/rubygems] Remove unnecessary string concatenation
- https://github.com/rubygems/rubygems/commit/81ccb3ab89
-
- Having a while loop over `heap_prepare` makes the GC logic difficult to
understand (it is difficult to understand whe... -
01:47 PM Bug #18061: Execshield test: libruby.so.N.N.N: FAIL: property-note test because no .note.gnu.property section found
- Here is a minimal reproducer to see the property-note test failure. The `./configure --enable-shared --with-gcc="gcc ...
-
12:04 PM Revision f50432fb (git): [rubygems/rubygems] Relax performance spec limit
- https://github.com/rubygems/rubygems/commit/eab417d0ce
-
- `test_thread_instrumentation_fork_safe` has been failing occasionaly
on Ubuntu and Arch. At this stage we're not sure... -
- See https://bugs.ruby-lang.org/issues/18564.
Ref: https://github.com/ruby/did_you_mean/pull/177
https://github.com/r... -
07:18 AM Bug #18811: PTY I/O not working on AIX 7.x
- mame (Yusuke Endoh) wrote in #note-2:
>
> This is my impression, but the maintenance state of AIX is not good. The... -
-
- > I sent the PR, https://github.com/ruby/ruby/pull/5938 .
The PR was merged.
> Then -Wl,-z,now is not logged in... -
05:51 AM
Bug #18781 (Closed): MJIT tests failing with Ubuntu focal with gcc-11 and some flags
- Applied in changeset commit:git|cfcf33f1270f78c5fb928d7a0927e6be02ec8900.
----------
.github/workflows/compilers.yml... -
- Applied in changeset commit:git|ec3542229b29ec93062e9d90e877ea29d3c19472.
----------
Ignore invalid escapes in regex... -
- Applied in changeset commit:git|c85d1cda86d75ee2c3f7b42f22c543409cb5a186.
----------
Fix Module#const_source_locatio... -
- Applied in changeset commit:git|7cda7fbbdc14f4262afaa94cdeb5a5987f1eb01a.
----------
Add Module#undefined_instance_m... -
- This reverts commit 9d927204e7b86eb00bfd07a060a6383139edf741.
-
- https://github.com/ruby/rdoc/commit/6d7bf24bb8
-
- ... only when the message string has a newline.
`p StandardError.new("foo\nbar")` now prints `#<StandardError: "foo\... -
- Currently only literal `0` and `1` are accepted as `read`/`write`
flags.
This patch allows other boolean arguments, C...
06/06/2022
- 10:25 PM Revision cfcf33f1 (git): .github/workflows/compilers.yml: annocheck: Fix a linker flag to pass MJIT tests.
- Set the linker flag `-Wl,-z,now` properly.
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
Fixes [Bug #18781] -
- Invalid escapes are handled at multiple levels. The first level
is in parse.y, so skip invalid unicode escape checks... -
06:31 PM Bug #18818: Thread waitq does not retain referenced objects, can lead to use after free.
- There might be a good reason we don't want to do this (or want to do it differently). But I can confirm that marking...
-
- Aha! Thanks, that makes perfect sense. And it does indeed fix it. I knew this toy scheduler wasn't *good*, and my o...
-
- @ko1 I saw this problem because fiber is not retained while waiting, because we have waiting threads but not waiting ...
-
- Unfortunately Mutex, Queue and probably other objects don't take a reference to the waiting fiber, so your fiber is b...
-
- * [Feature #18788] Support passing Regexp options as String to Regexp.new (jeremyevans0)
* Do we want to add suppo... -
- If an autoload exists for a constant, but the path for the autoload
was required, const_source_location would return ... - 05:47 PM Revision 653e517e (git): Use bindgen to import Ruby constants wherever possible. (#5943)
- Constants that can't be imported via bindgen should have
a comment saying why not. -
05:38 PM Feature #18183: make SecureRandom.choose public
- One option would be to extend `Random::Formatter#alphanumeric` to have an optional "alphabet":
```ruby
def alphan... -
- My bad for not searching the old topics.
In this module, (most of) the method name describes the output, not the p... -
- I don't think `SecureRandom.random_string(args, len)` describes the behavior, neither.
Matz.
-
- @matz The OP proposed `random_string`. What do you think about it?
-
- My bad. args.sample(random: SecureRandom) is not a replacement for SecureRandom.choose(*args,len).
But still, choose... -
- `SecureRandom.choose(*args)` is not intuitive from my POV. Use `args.sample(random: SecureRandom)`.
Matz.
-
-
-
- Previously `(2..).cover?("2"..)` was false, but
`(..2).cover?(.."2")` was true. This changes it so both are false,
t... -
- Implements [Feature #12655]
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org> -
- Treats:
::rm
::rm_f
::rm_r
::rm_rf
::remove_entry_secure
https://github.com/ruby/fileutils/commi... - 03:07 PM Revision f2f8c0b3 (git): * 2022-06-07 [ci skip]
- 03:06 PM Revision 6fc16e74 (git): [ruby/open-uri] [DOC] Fix markup for `URI.open`
- * Add missing slash.
https://github.com/ruby/open-uri/commit/40023e63da -
- https://github.com/ruby/rdoc/commit/fec1ab2e41
-
- It was being explicitly required from `Gem::Specification` but also a
strange autoload was set for it at `Gem::Versio... -
- 09:13 AM Revision 4bc7cef8 (git): [ruby/cgi] jruby support
- https://github.com/ruby/cgi/commit/93326fb622
-
- The tests fail randomly on some platforms.
http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20220605T213004Z.fa... -
- "choose" is named just for an internal API. We need another good name if we make it public. Continue to discuss in #1...
-
- 02:40 AM Revision 93555e01 (git): * 2022-06-06 [ci skip]
-
-
- THREAD_MODEL is exported already, so this matches that. Exporting this
is simpler than inspecting configure_args and... -
12:41 AM Bug #18790: cannot load such file -- digest (LoadError)
- There is a similar issue with Red Hat Enterprise Linux 8. To install `libyaml-devel` package, it needs 'codeready-bui...
06/05/2022
-
- The attached script (and/or others like it) can cause SEGV in 3.0, 3.1, and master. It has always behaved as expecte...
-
- I read through [the doc of `SecureRandom`](https://ruby-doc.org/stdlib-3.1.2/libdoc/securerandom/rdoc/SecureRandom.ht...
- 06:18 AM Revision 5ce0be02 (git): * 2022-06-05 [ci skip]
-
-
- schneems (Richard Schneeman) wrote in #note-16:
> I am worried about the memory implications for enabling this by de... -
- Reproduction server:
```
require 'socket'
# Set based on CPU count
CONCURRENCY = 8
server = TCPServer.new(...
06/04/2022
-
- So that an exception raises by non-existent command, not via shell.
https://github.com/ruby/rdoc/commit/fd94dce69d -
- https://github.com/ruby/rdoc/commit/6b1a011243
-
- https://github.com/ruby/rdoc/commit/83051403d6
-
- https://github.com/ruby/rdoc/commit/ce63794fde
-
- `IO.popen` does that job.
https://github.com/ruby/rdoc/commit/3bbbc5ac84 -
- https://github.com/ruby/rdoc/commit/47a1aef447
-
- matz (Yukihiro Matsumoto) wrote in #note-24:
> When investigating #18435, I realized the visibility of a method is n...