Activity
From 08/09/2024 to 08/15/2024
08/15/2024
-
10:12 PM Bug #20675: Parse error with required kwargs and omitted parens
- The reason for this inconsistency is backwards compatibility, so as not to break existing code when omitted hash valu...
-
04:04 PM Bug #20675: Parse error with required kwargs and omitted parens
- I believe Matz was talking about changing the behavior of `f k:<newline>`, so method definition `def foo k:<newline>`...
-
02:16 AM Bug #20675: Parse error with required kwargs and omitted parens
- This change is compatibility issue and I counted the number of `def foo k:<newline>` patterns and I found about 4000 ...
-
08:00 PM Revision abc04e89 (git): Avoid hash allocation for certain proc calls
- Previous, proc calls such as:
```ruby
proc{|| }.(**empty_hash)
proc{|b: 1| }.(**r2k_array_with_empty_hash)
```
both... -
06:33 PM Revision 2c6e16eb (git): Don't assume st_data_t and VALUE are the same in rb_gc_impl_object_id
-
05:34 PM Revision de28ef7d (git): [PRISM] Use src encoding not ext encoding
-
05:34 PM Revision eb08a280 (git): [PRISM] test_invalid_jump assertion updates for prism
-
05:34 PM Revision a402b18c (git): [PRISM] test_syntax_check assertion updates for prism
-
04:59 PM Revision 2d66ef71 (git): Show anonymous and ambiguous params in ISeq disassembly
- Previously, in the disasesmbly for ISeqs, there's no way to know if the
anon_rest, anon_kwrest, or ambiguous_param0 f... -
04:52 PM Revision 33bffde9 (git): [DOC] Tweaks for Array#at
-
04:50 PM Revision 5cb6954b (git): [ruby/prism] Fix up lex result constants
- https://github.com/ruby/prism/commit/084baca463
-
04:49 PM Revision d2361ba1 (git): [DOC] Tweaks for Array#push
-
04:48 PM Revision edda29a1 (git): [DOC] Fix Related for Array#all?
-
04:46 PM Revision 1f994683 (git): [DOC] Tweaks for Array#any?
-
04:40 PM Revision cbf508da (git): [ruby/prism] Special error for too short unicode errors
- https://github.com/ruby/prism/commit/9f1f7d08bd
-
02:38 PM Revision 8312c5be (git): Fix GC_ASSERT for gc.c and gc/default.c
- gc.c mistakenly defined GC_ASSERT as blank, which caused it to be a
no-op. This caused all assertions in gc.c and gc/... -
01:33 PM Revision 923e36ab (git): [ruby/rdoc] Fix sidebar scroll again and add missing footer back
- (https://github.com/ruby/rdoc/pull/1154)
* Add missing footers
In #1152 the footer partial was only added to the in... -
10:11 AM Bug #20678 (Closed): Doxygen document doesn't print Ruby C APIs properly
-
10:11 AM Bug #20678: Doxygen document doesn't print Ruby C APIs properly
- Ufuk, thank you for info!
I found the document about the `rb_scan_args` (`ruby_doxygen_rb_scan_args.png`) by click... -
10:04 AM Bug #20678: Doxygen document doesn't print Ruby C APIs properly
- I believe it is being generated. Probably not where you expect it to be, though: https://docs.ruby-lang.org/capi/en/m...
-
09:53 AM Bug #20678 (Closed): Doxygen document doesn't print Ruby C APIs properly
- I am looking for how to see a list of Ruby C API descriptions written in the comment area by a command.
For exampl... - 08:16 AM Revision 2a933609 (git): Delete unnecessary rubocop disable comment
-
06:55 AM Revision 8a7e6f68 (git): Improve base time of assert_linear_performance (#11369)
- Remove `.ceil` from base time calculation that makes 10x gap.
This will make the assertion more strict and also less ... - 03:09 AM Revision a1d8ef6e (git): Bump github/codeql-action from 3.26.1 to 3.26.2
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.1 to 3.26.2.
- [Release notes](https:... -
01:14 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- Ah. I might have to add some feature detection to the configure script for this when deciding if BTI/PAC is available...
08/14/2024
-
08:23 PM Revision fd974f5d (git): Increase timeout of test_finalizer
- The test is timing out on lpi4a so a longer timeout should fix it.
-
08:16 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- byroot (Jean Boussier) wrote in #note-36:
> As for the API, my two cents is that it would make the most sense in `Pr... -
07:39 PM Revision 09bf3c9d (git): [PRISM] Trigger moreswitches off shebang
-
07:27 PM Bug #20675: Parse error with required kwargs and omitted parens
- I agree that `f k:` at end of line should be parsed as `f(k:)`. Even though it is backward incompatible, it can be de...
-
06:06 PM Revision 002e785e (git): [ruby/irb] Fix kill pager pid throwing Errno::ESRCH when pager
- process already terminated
(https://github.com/ruby/irb/pull/989)
https://github.com/ruby/irb/commit/949f032e9b -
05:49 PM Revision 0610f1b0 (git): Fix crash when GC runs during finalizers at shutdown
- We need to remove from the finalizer_table after running all the
finalizers because GC could trigger during the final... -
05:47 PM Revision 85f99b38 (git): [DOC] Tweaks to Array#all? (#11365)
-
05:40 PM Revision a952ea24 (git): [ruby/prism] Callback on shebang switches
- Add the ability to receive a callback when the parser encounters a
shebang that contains additional switches after th... -
05:19 PM Revision 66312ad9 (git): Re-initialize vm->ractor.sched.lock after fork (#11372)
- [Bug #20633] Re-initialize vm->ractor.sched.lock after fork
Previously under certain conditions it was possible to e... -
04:35 PM Feature #20676: Pathnames aren't Comparable
- It looks like I got it wrong. `<=>` does case-sensitive matching and doesn't behave the way I thought it did. General...
-
01:48 PM Feature #20676: Pathnames aren't Comparable
- > I think we should add Pathname#start_with?(path) for convenience, or maybe Pathname#inside?(path).
Yes, having m... -
01:20 PM Feature #20676: Pathnames aren't Comparable
- I think we should add `Pathname#start_with?(path)` for convenience, or maybe `Pathname#inside?(path)`.
FWIW it alrea... -
12:59 PM Feature #20676: Pathnames aren't Comparable
- Hanmac (Hans Mackowiak) wrote in #note-4:
> nobu (Nobuyoshi Nakada) wrote in #note-2:
> > Probably you may want to ... -
12:50 PM Feature #20676: Pathnames aren't Comparable
- nobu (Nobuyoshi Nakada) wrote in #note-2:
> Probably you may want to do:
>
> ```ruby
> (Pathname("/a/b/c").to_s+... -
12:01 PM Feature #20676 (Feedback): Pathnames aren't Comparable
-
11:56 AM Feature #20676: Pathnames aren't Comparable
- Probably you may want to do:
```ruby
(Pathname("/a/b/c").to_s+"/").start_with?(Pathname("/a/b").to_s+"/")
``` -
08:00 AM Feature #20676: Pathnames aren't Comparable
- > to check if pathnames are subdirectories of each other
I don't understand.
```ruby
>> Pathname("/a/b").to_s... -
04:28 PM Revision 88954a0e (git): [ruby/prism] Tweak inspect representation of `Prism::Location`
- This PR tweaks inspect representation of `Prism::Location`.
## Before
During debugging, the meaning of `@location=h... -
02:51 PM Revision 264175db (git): [DOC] Update comment about how object ID is calculated
- The object ID no longer treats symbols in a special way so we can simplify
the comment about how it is calculated. -
08:41 AM Misc #20661: Stop retrying tests in `make test-all` command by default
- I add some background.
As a result of the introduction of Launchable (#20254), it was discovered that many test fa... - 07:01 AM Revision d0954741 (git): Update bundled gems list as of 2024-08-14
-
05:48 AM Bug #20677: error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- @kjtsanaktsidis Could you take a look?
-
04:32 AM Bug #20677 (Closed): error: mach-o section specifier requires a segment whose length is between 1 and 16 characters
- ruby (the development version as of 2024-08-11) does not build on macOS 11 or earlier with Apple Clang 1300 or earlie...
-
04:06 AM Revision f2f177ed (git): [ruby/irb] Improve easter_egg logo resolution
- (https://github.com/ruby/irb/pull/987)
https://github.com/ruby/irb/commit/ab394db93f -
03:24 AM Revision e7046f1f (git): Increase the default timeout in assert_darwin_vm_dump_works
- 03:14 AM Revision 983d91cf (git): Bump github/codeql-action from 3.26.0 to 3.26.1
- Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.26.1.
- [Release notes](https:...
08/13/2024
-
11:13 PM Revision b20957bd (git): [ruby/resolv] test_dns: Fix failure on Windows
- (https://github.com/ruby/resolv/pull/58)
test_dns: Fix failure on Windows
1. Switch to #with_udp_and_tcp helper met... -
09:43 PM Feature #20676 (Feedback): Pathnames aren't Comparable
- π
I was working with Pathnames recently and noticed that I could do:
```rb
Pathname("/a/b").to_s <= Pathname("... -
09:09 PM Revision 094e5336 (git): [ruby/resolv] Reuse open TCP connection
- [RFC7766] Section 5 recommends stub resolvers to reuse open TCP
connections to a nameserver.
[RFC7766]: https://data... -
09:09 PM Revision 4be9b72f (git): [ruby/resolv] Fix TCP fallback with multiple nameservers
- Under the following conditions the exception
`Resolv::DNS::Requester::RequestError: host/port don't match` is raised:... -
08:56 PM Revision 525008cd (git): Delete newarraykwsplat
- The pushtoarraykwsplat instruction was designed to replace newarraykwsplat,
and we now meet the condition for deletio... -
08:51 PM Bug #20670 (Closed): fork deadlocks in child process due to timer thread
- Fixed by https://github.com/ruby/ruby/commit/87a85550edd786665e081b355c6af62c4854b1d7
-
07:53 PM Revision b80b8399 (git): Don't set stack end in rb_gc_mark_roots
- We don't need to set the stack end in rb_gc_mark_roots because it is
already set in mark_current_machine_context. -
07:37 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- Needs a bit of polish (e.g. doc and spec), but that's essentially what I think we should do: https://github.com/ruby/...
-
05:58 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- It might make sense to split this ticket into two requests: one for `Process.argv` or similar and one for re-executin...
-
05:25 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- As for the API, my two cents is that it would make the most sense in `Process`. e.g. `Process.argv`, such as:
```b... -
05:19 PM Feature #6648: Provide a standard API for retrieving all command-line flags passed to Ruby
- This need came up again in https://github.com/rubygems/rubygems/pull/7933.
AFAICT there is currently no good way f... -
06:52 PM Revision 87a85550 (git): Re-initialize vm->ractor.sched.lock after fork
- Previously under certain conditions it was possible to encounter a
deadlock in the forked child process if ractor.sch... -
01:19 PM Bug #20675: Parse error with required kwargs and omitted parens
- I think this would be *great* and would *love* to use keyword parameters without parenthesis...but I don't know how c...
-
02:12 AM Bug #20675 (Closed): Parse error with required kwargs and omitted parens
- As pointed out in https://github.com/mruby/mruby/issues/6268, keyword arguments without surrounding parens are a bit ...
- 01:10 PM Revision 908305a2 (git): Sync rdoc
-
12:41 PM Revision a6581114 (git): [ruby/prism] Fix up spacing in generated node.rb
- https://github.com/ruby/prism/commit/50d79b734b
-
06:44 AM Bug #20674 (Rejected): Time zone conversion issue Time.at
-
06:42 AM Bug #20674 (Third Party's Issue): Time zone conversion issue Time.at
- ```ruby
require 'active_support'
require 'active_support/core_ext'
Time.zone = "Central Time (US & Canada)"
p T... -
03:56 AM Bug #20674 (Rejected): Time zone conversion issue Time.at
- `Time.zone=` method is not defined in Ruby itself, ~~probably defined by ActiveSupport~~, I don't know from where it ...
-
05:47 AM Revision 436d23f8 (git): Make sure to wait for the thread to exit in TestProcess#test_wait_and_sigchild
-
03:35 AM Bug #20662 (Feedback): pack("g") completely discards any actual NaN value and always packs the same single-precision bytes for a NaN
- I'm curious about your use case.
For what purpose and how do you want to use it? -
03:18 AM Bug #20671 (Closed): Do not show "unused block" warning on `send`
- Matz accepted this idea so now I merged it.
-
03:17 AM Revision d5afa2cc (git): do not show unused block on `send`
- Some case it is difficult to know the calling method uses a block
or not with `send` on a general framework. So this ... - 01:48 AM Revision eedf6c35 (git): Revert change of "mingw-ucrt" platform string
- ... of commit 00176cd40fe9f385231e9c20b956fc4a84d240b9.
The reverted change was made only for constistency, as discu... -
01:28 AM Revision 00e2e24e (git): Launchable: Fix condition for bootstraptest
08/12/2024
-
06:44 PM Revision d012f6d4 (git): [ruby/prism] Add sample for generating tags
- https://github.com/ruby/prism/commit/7c9ca47ac5
-
04:18 PM Bug #20674 (Rejected): Time zone conversion issue Time.at
- `Time.at` converts the epoch time to the local time zone But there seems a weird case with Central Time (US & Canada)...
-
01:33 PM Revision 568d7ab7 (git): Fix memory leak reported in -test-/random/loop.c
- RUBY_TYPED_DEFAULT_FREE will only free the rand_loop_t, but it will cause
the buf to be leaked. This commit fixes the... -
09:09 AM Bug #20344 (Closed): argument stack underflow (-1)
- Applied in changeset commit:git|992596fb7af18a7f472589a607d0eb3fbb03b49a.
----------
Fix next inside block argument ... -
09:09 AM Revision 992596fb (git): Fix next inside block argument stack underflow
- [Bug #20344]
Fix compile_next adding removable adjust label - 07:01 AM Revision 2a7da0b6 (git): Update bundled gems list as of 2024-08-12
08/11/2024
-
01:04 PM Revision ca5b7276 (git): compile.c: don't allocate empty default values list
- It just wastes memory.
-
09:58 AM Bug #20666: Segmentation fault instead of LoadError exception
- Did some minimising.
# Three sources:
## `extconf.rb`
> require 'mkmf'
> create_header
> create_makefile 'good'
## `... -
07:04 AM Revision 1fd0a1b4 (git): Fix sign-conversion warning
- ```
../../.././include/ruby/internal/special_consts.h:349:36: error: conversion to βVALUEβ {aka βlong unsigned intβ} ... -
06:57 AM Revision 1db85862 (git): Show mkmf.log when failed
08/10/2024
-
08:04 PM Feature #20673 (Feedback): Enable native SOCKS support by default
- I'd like to see future Rubies have native SOCKS support enabled by default.
Currently Rubies must be compiled with... -
07:14 PM Bug #20672: UNIXSocket.pair transmitting data between pids looks flaky
- byroot (Jean Boussier) wrote in #note-2:
> Alright I've figured it out.
[...]
>
> ```ruby
> received_w = main_c... -
09:41 AM Bug #20672 (Rejected): UNIXSocket.pair transmitting data between pids looks flaky
- Alright I've figured it out.
`recv_io` creates an `IO` instance, that you then discard. But that `IO` instance onc... -
09:22 AM Bug #20672: UNIXSocket.pair transmitting data between pids looks flaky
- I'm able to reproduce with large enough message (e.g. `-c 4000` on my machine).
However if I change:
```ruby
r... -
02:43 AM Bug #20672 (Rejected): UNIXSocket.pair transmitting data between pids looks flaky
- I have code that uses UNIXSocket.pair and fork to send data between parent and child.
It seems to work fine for a ... -
05:36 PM Revision 21a9d766 (git): Fix flag test macro
- `RBOOL` is a macro to convert C boolean to Ruby boolean.
-
05:36 PM Revision 04d57e2c (git): Evaluate macro arguments just once
- And fix unclosed parenthesis.
-
03:19 PM Revision 9416bfb8 (git): Increase timeout of test-bundler-parallel
- Even if it succeeds, it takes almost 40 minutes.
- 03:10 PM Revision 00176cd4 (git): fix ucrt arch
- 03:10 PM Revision f1224e55 (git): fix i386-ucrt build
-
10:41 AM Revision b1f4222f (git): Cherry-pick test for [Bug #20668]
- The bug didn't impact master because this was largely refactored,
but it's still valuable to add the test for it to p... -
08:42 AM Revision ad23bbe5 (git): [ruby/prism] [Doc] Tweak the docs for lex APIs
- `Prism.lex` and `Prism.lex_file` return `ParseLexResult` instead of `Array`.
`Prism::parse_lex` and `Prism::parse_lex... -
08:09 AM Revision 6ee9a08d (git): rb_setup_fake_ary: use precomputed flags
- Setting up the fake array is a bit more expensive than would be
expected because `rb_ary_freeze` does a lot of checks... -
07:27 AM Revision 6fd660e6 (git): merge revision(s) 657f4b99f61a15e21584b87f7b206933d116589b:
- Update bundled gems list as of 2024-08-02
-
07:24 AM Revision c307c2b6 (git): merge revision(s) 54d26221b4c4cfc46048f30892c626db69ce9244:
- .travis.yml: Allow failures for ppc64le and s390x.
Because Travis ppc64le/s390x are unstable.
ppc64... -
01:44 AM Bug #20671 (Closed): Do not show "unused block" warning on `send`
- Let's disable "unused block" warning on `send` because now it is hard to recognize the calling method accepts a block...
-
01:30 AM Feature #20594: A new String method to append bytes while preserving encoding
- Alan's proposal looks good to me. I don't think it is Ruby to design such an ordinary API with extreme care for optim...
-
01:17 AM Bug #20670: fork deadlocks in child process due to timer thread
- Thank you!
08/09/2024
-
08:28 PM Revision 7b7dde37 (git): [ruby/psych] Guard from memory leak in Psych::Emitter#start_document
- When an exception is raised, it can leak memory in `head`. There are two
places that can leak memory:
1. `Check_Type... -
08:06 PM Revision 4e85b6b4 (git): rb_str_bytesplice: skip encoding check if encodings are the same
- If both strings have the same encoding, all this work is useless.
-
08:06 PM Revision 3bac5f6a (git): string.c: add fastpath in str_ensure_byte_pos
- If the string only contain single byte characters we can
skips all the costly checks. -
08:06 PM Revision a332367d (git): string.c: Add fastpath to single_byte_optimizable
- `rb_enc_from_index` is a costly operation so it is worth avoiding
to call it for the common encodings.
Also in the c... -
08:06 PM Bug #20670 (Closed): fork deadlocks in child process due to timer thread
- We've been seeing an occasional failure in the Rails CI related to a test which forks and I managed to reduce it to t...
-
08:02 PM Revision 5a570421 (git): [DOC] Regexp.last_match returns `$~`, not `$!`
-
07:38 PM Revision ee482f48 (git): Add psych expand tabs commit to .git-blame-ignore-revs [ci skip]
-
07:35 PM Revision d1474aff (git): [ruby/psych] Convert tabs to spaces in test/psych/test_yaml.rb
- https://github.com/ruby/psych/commit/64bfc308f8
-
07:35 PM Revision 712ac99e (git): [ruby/psych] Convert missed tabs to spaces in C files
- https://github.com/ruby/psych/commit/74a6b4d226
-
07:31 PM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- Isn't it fair to assume any Exception from calling `Marshal.load` is an error while de-marshaling the data?
I think ... -
03:41 PM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- > We may be able to create a sub-class of class LoadError < ArgumentError but it fundamentally seems wrong to me (sho...
-
07:27 AM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- Changed the proposal to be about one error class. Thanks, KJ!
-
07:24 AM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- kjtsanaktsidis (KJ Tsanaktsidis) wrote in #note-1:
> I agree it might be nice if Marshal had its own error class lik... -
03:31 AM Feature #20669: Add Marshal::MarshalError class to differentiate ArgumentErrors
- I agree it might be nice if Marshal had its own error class like `MarshalError` or some such. However, I don't really...
-
06:51 PM Revision c8708c72 (git): Add expand tabs commit in psych to .git-blame-ignore-revs
-
06:29 PM Revision e63a2115 (git): [ruby/psych] Convert tabs to spaces in C files
- https://github.com/ruby/psych/commit/e7d64c9848
-
03:35 PM Bug #20634 (Closed): ruby uses 1/2 (7 out of 16) cores for 16 ractors with RUBY_MAX_CPU=16 environment variable set
-
08:31 AM Bug #20634: ruby uses 1/2 (7 out of 16) cores for 16 ractors with RUBY_MAX_CPU=16 environment variable set
- I just checked - the problem doesn't repro-es on HEAD (ruby 3.4.0dev (2024-08-09T03:16:23Z master f57167d338) [x86_64...
-
02:27 PM Revision c91ec7ba (git): Remove rb_gc_impl_objspace_mark
- It's not necessary for the GC implementation to call rb_gc_mark_roots
which calls back into the GC implementation's r... -
02:15 PM Bug #20663 (Rejected): Reading characters from IO does not recover gracefully from bad data pushed via IO#ungetc
-
01:47 PM Bug #20663: Reading characters from IO does not recover gracefully from bad data pushed via IO#ungetc
- After reviewing the sources, I see that this behavior is a consequence of how character conversion is handled. Fetch...
-
01:20 PM Revision 2bd5dc47 (git): string.c: str_capacity don't check for immediates
- `STR_EMBED_P` uses `FL_TEST_RAW` meaning we already assume `str`
isn't an immediate, so we can use `FL_TEST_RAW` here... -
01:20 PM Revision af44af23 (git): str_independent: add a fastpath with a single flag check
- If we assume that most strings we modify are not frozen and
are independent, then we can optimize this case by replac... -
01:13 PM Bug #20662: pack("g") completely discards any actual NaN value and always packs the same single-precision bytes for a NaN
- https://github.com/ruby/ruby/pull/11352
I'm uncertain that it is a nice idea to expose such internals of `Float` t... -
04:14 AM Bug #20490: Process.waitpid2(-1, Process::WNOHANG) misbehaves on Ruby 3.1 & 3.2 with detached process
- Apologies I missed this - I just rebased the branch, I think it should be OK for a stable backport to 3.2.
-
03:52 AM Misc #20661: Stop retrying tests in `make test-all` command by default
- I have no objection to disabling automatic re-runs, but one thing:
> Just click the "Re-run jobs" button via the G... -
03:16 AM Revision f57167d3 (git): Increase timeout in `test_darwin_invalid_call` method