Since #10209 we've been noticing that on macos after running make clean the coroutine/arm64/Context.S file is missing, causing
subsequent make calls to fail because Context.S is needed to build Context.o.
The reason this is happening is because macos is case-insensitive so the .s looks for coroutine/arm64/Context.s and finds coroutine/arm64/Context.s. This does not happen on linux because the
filesystem is case sensitive.
I attempted to use find because it is case sensitive regardless of
filesystem, but it was a lot slower than rm since we can't pass
multiple file names the same way to find.
Reverting this small part of #10209 fixes the issue for macos and it
wasn't clear that those changes were strictly necessary for the rest of
the PR.
We changed the original code to use rm instead of delete because it
is not standarized on POSIX.
Added by eileencodes (Eileen Uchitelle) over 1 year ago
Fix macos bug deleting too many files
Since #10209 we've been noticing that on macos after running
make cleanthecoroutine/arm64/Context.Sfile is missing, causingsubsequent make calls to fail because
Context.Sis needed to buildContext.o.The reason this is happening is because macos is case-insensitive so the
.slooks forcoroutine/arm64/Context.sand findscoroutine/arm64/Context.s. This does not happen on linux because thefilesystem is case sensitive.
I attempted to use
findbecause it is case sensitive regardless offilesystem, but it was a lot slower than
rmsince we can't passmultiple file names the same way to
find.Reverting this small part of #10209 fixes the issue for macos and it
wasn't clear that those changes were strictly necessary for the rest of
the PR.
We changed the original code to use
rminstead ofdeletebecause itis not standarized on POSIX.