Patch setting of oneDNN fpmath mode in PyTorch CI#405
Merged
Conversation
Radu2k
approved these changes
Nov 17, 2025
78b5dd5 to
8707360
Compare
nSircombe
previously approved these changes
Nov 17, 2025
Contributor
nSircombe
left a comment
There was a problem hiding this comment.
Patch looks ok - but of course the CI is now failing...
ONEDNN_DEFAULT_FPMATH_MODE was set as an environment variable but this was not propagated to the Docker container.
8707360 to
3f6efaf
Compare
Contributor
Author
|
@nSircombe I've just pushed an extra patch to make sure that all "test" jobs (not build jobs) run until they finish or fail. (Currently, if one "test" job fails, it kills all of the other tests so we never know if they're still okay.) Needs reapproval. |
Contributor
Author
|
Going to merge as the change after Nathan's approval was trivial (albeit very useful) and I'd like to get the CI changes in so I can see if removing Renato's patch fixes the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONEDNN_DEFAULT_FPMATH_MODEwas set as an environment variable but this was not propagated to the Docker container.