Make text generation work with ministral model.

[comfyanonymous]

Needs template before it works properly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e5719387-fb83-493f-9fb3-f6ed92fc471a

📥 Commits

Reviewing files that changed from the base of the PR and between 402ff1c and c1eb882.

📒 Files selected for processing (1)

• comfy/text_encoders/llama.py

---

📝 Walkthrough

Walkthrough

The changes modify the Ministral3_3B model configuration and class inheritance structure in comfy/text_encoders/llama.py. A stop_tokens field with default value [2] is added to Ministral3_3BConfig. The Ministral3_3B class inheritance chain is expanded to include BaseQwen3 and BaseGenerate mixins, enabling the use of BaseQwen3.logits for logits computation and BaseGenerate.generate for generation control flow with integrated stop token handling.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective of the PR: enabling text generation functionality for the Ministral model by adding stop_tokens and adjusting class inheritance.
Description check	✅ Passed	The description is related to the changeset, noting that a template is needed for the ministral model to work properly, which aligns with the generation-related modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}