Skip to content

[Partner Nodes] add ByteDance Seed LLM node#13919

Merged
Kosinkadink merged 2 commits into
masterfrom
feat/api-nodes/bytedance-llm
May 18, 2026
Merged

[Partner Nodes] add ByteDance Seed LLM node#13919
Kosinkadink merged 2 commits into
masterfrom
feat/api-nodes/bytedance-llm

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented May 15, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new ByteDance Seed 2.0 text generation node to ComfyUI. The module defines model metadata and API configuration, implements dynamic input UI for multimodal context (images and videos), and builds the request to the BytePlus endpoint with token-based pricing calculation. The execute method validates inputs, constructs content blocks from uploaded media, calls the remote API, validates responses for errors and refusals, extracts assistant text, and returns the result. An extension class registers the node for loading.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 22.22% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a ByteDance Seed LLM node to the partner nodes collection.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description is a checklist format related to API node changes, pricing updates, QA, and communications—directly relevant to the changeset which adds a new ByteDance Seed LLM node with pricing support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_api_nodes/nodes_bytedance_llm.py`:
- Around line 223-225: The code directly indexes model["model"] and
model["temperature"] and then looks up SEED_MODELS[model_label], which can raise
KeyError on malformed payloads; update the logic in the handler that uses
model_label/temperature (the variables model_label, temperature, model_id and
the SEED_MODELS lookup) to first validate that the keys "model" and
"temperature" exist in the incoming model dict and that model_label is present
in SEED_MODELS, and if any check fails raise a clear ValueError (e.g. "missing
'model' key" or "unsupported model: <label>") so downstream error handling is
predictable.
- Around line 193-201: The PriceBadge token-rate literals for the "mini" and
"lite" branches are out of sync with the runtime constant
_SEED_PRICES_PER_MILLION; update these hardcoded usd arrays (the branch that
produces "type": "list_usd") to derive per-1K-token values from
_SEED_PRICES_PER_MILLION instead of using the current literals so UI hints match
runtime pricing. Locate the conditional branches that check $contains($m,
"mini") and $contains($m, "lite") in comfy_api_nodes/nodes_bytedance_llm.py and
replace the fixed usd arrays with values computed from _SEED_PRICES_PER_MILLION
(divide the per-million price by 1000) for both lower and upper bounds, keeping
the existing format object intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4efb8427-38c8-45be-95d9-fd9691205b4a

📥 Commits

Reviewing files that changed from the base of the PR and between 04856ac and aa2c6a8.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/bytedance_llm.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_bytedance_llm.py

Comment thread comfy_api_nodes/nodes_bytedance_llm.py
Comment thread comfy_api_nodes/nodes_bytedance_llm.py
@Kosinkadink Kosinkadink merged commit 164a9d4 into master May 18, 2026
17 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/bytedance-llm branch May 22, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants