Optional OpenGL buffers in SolidVoxelise#131
Open
AspenEyers wants to merge 1 commit into
Open
Conversation
14f4fc7 to
8eb4c8b
Compare
Lets users fill the Mesh AUX buffers from however they want and reuse the SolidVoxelise code. Signed-off-by: Aspen Eyers <aspen.eyers@missionsystems.com.au>
8eb4c8b to
2b9f1cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using SolidVoxelise on a branch where I have removed the requirement for meshes to be first uploaded to OpenGL
and then pushed into the GVDB AUX buffers.
It removes the requirement on having an existing OpenGL context and lets users upload directly to GVDB.
Personally, I've found it quite useful to use SolidVoxelise when uploading data from .obj files.
Defaulting the use_opengl to true means that it won't affect existing code, but it gives people more flexibility.
Let me know what you think.
Cheers,
Aspen
Signed-off-by: Aspen Eyers aspen.eyers@missionsystems.com.au