Disable heartbeats if hearbeat set to 0#469
Closed
carlhoerberg wants to merge 3 commits into
Closed
Conversation
9b551a9 to
ff660b4
Compare
squaremo
requested changes
Oct 17, 2018
squaremo
reviewed
Oct 29, 2018
ressom
reviewed
Jul 24, 2019
| @@ -227,7 +227,7 @@ C.open = function(allFields, openCallback0) { | |||
| tunedOptions.channelMax = | |||
| negotiate(fields.channelMax, allFields.channelMax); | |||
| tunedOptions.heartbeat = | |||
There was a problem hiding this comment.
I know this PR is old and @squaremo has reviewed / suggested a change, but I am thinking this is a simpler, clearer solution.
Suggested change
| tunedOptions.heartbeat = | |
| if (allFields.heartbeat !== 0) { | |
| tunedOptions.heartbeat = | |
| negotiate(fields.heartbeat, allFields.heartbeat); | |
| } |
This would also facilitate revert of the change @ line 192 above.
Collaborator
|
@carlhoerberg Any chance you could finish this PR? |
Collaborator
|
Implemented via #853 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #467