Skip to content

Commit 38fde2e

Browse files
Fix download_media url in GoogleDisplayVideo360SDFtoGCSOperator (#22479)
1 parent 0f0a1a7 commit 38fde2e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

β€Žairflow/providers/google/marketing_platform/hooks/display_video.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
class GoogleDisplayVideo360Hook(GoogleBaseHook):
2828
"""Hook for Google Display & Video 360."""
2929

30-
_conn = None # type: Optional[Any]
30+
_conn: Optional[Resource] = None
3131

3232
def __init__(
3333
self,

β€Žairflow/providers/google/marketing_platform/operators/display_video.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ def execute(self, context: 'Context') -> str:
692692
operation_state = hook.get_sdf_download_operation(operation_name=self.operation_name)
693693

694694
self.log.info("Creating file for upload...")
695-
media = hook.download_media(resource_name=operation_state)
695+
media = hook.download_media(resource_name=operation_state["response"]["resourceName"])
696696

697697
self.log.info("Sending file to the Google Cloud Storage...")
698698
with tempfile.NamedTemporaryFile() as temp_file:

β€Žtests/providers/google/marketing_platform/operators/test_display_video.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,6 @@ class TestGoogleDisplayVideo360SDFtoGCSOperator(TestCase):
354354
@mock.patch("airflow.providers.google.marketing_platform.operators.display_video.tempfile")
355355
def test_execute(self, mock_temp, gcs_mock_hook, mock_hook):
356356
operation_name = "operation_name"
357-
operation = {"key": "value"}
358357
operation = {"response": {"resourceName": "test_name"}}
359358
gzip = False
360359

@@ -388,7 +387,9 @@ def test_execute(self, mock_temp, gcs_mock_hook, mock_hook):
388387

389388
mock_hook.return_value.download_media.assert_called_once()
390389
mock_hook.return_value.download_media.assert_called_once_with(
391-
resource_name=mock_hook.return_value.get_sdf_download_operation.return_value
390+
resource_name=mock_hook.return_value.get_sdf_download_operation.return_value["response"][
391+
"resourceName"
392+
]
392393
)
393394

394395
mock_hook.return_value.download_content_from_request.assert_called_once()

0 commit comments

Comments
 (0)