Skip to content

Commit 544d658

Browse files
MaksYermakpotiuk
authored andcommitted
Change CloudDatastoreExportEntitiesLink to StorageLink
1 parent b3cc2f5 commit 544d658

File tree

3 files changed

+4
-29
lines changed

3 files changed

+4
-29
lines changed

β€Žairflow/providers/google/cloud/links/datastore.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -52,30 +52,6 @@ def persist(
5252
)
5353

5454

55-
class CloudDatastoreExportEntitiesLink(BaseGoogleLink):
56-
"""Helper class for constructing Cloud Datastore Export Entities Link"""
57-
58-
name = "Export Entities"
59-
key = "export_conf"
60-
format_str = DATASTORE_EXPORT_ENTITIES_LINK
61-
62-
@staticmethod
63-
def persist(
64-
context: "Context",
65-
task_instance,
66-
output_url: str,
67-
):
68-
task_instance.xcom_push(
69-
context=context,
70-
key=CloudDatastoreExportEntitiesLink.key,
71-
value={
72-
"project_id": task_instance.project_id,
73-
"bucket_name": task_instance.bucket,
74-
"export_name": output_url.split('/')[3],
75-
},
76-
)
77-
78-
7955
class CloudDatastoreEntitiesLink(BaseGoogleLink):
8056
"""Helper class for constructing Cloud Datastore Entities Link"""
8157

β€Žairflow/providers/google/cloud/operators/datastore.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
from airflow.providers.google.cloud.hooks.gcs import GCSHook
2626
from airflow.providers.google.cloud.links.datastore import (
2727
CloudDatastoreEntitiesLink,
28-
CloudDatastoreExportEntitiesLink,
2928
CloudDatastoreImportExportLink,
3029
)
30+
from airflow.providers.google.common.links.storage import StorageLink
3131

3232
if TYPE_CHECKING:
3333
from airflow.utils.context import Context
@@ -78,7 +78,7 @@ class CloudDatastoreExportEntitiesOperator(BaseOperator):
7878
'labels',
7979
'impersonation_chain',
8080
)
81-
operator_extra_links = (CloudDatastoreExportEntitiesLink(),)
81+
operator_extra_links = (StorageLink(),)
8282

8383
def __init__(
8484
self,
@@ -138,10 +138,10 @@ def execute(self, context: 'Context') -> dict:
138138
state = result['metadata']['common']['state']
139139
if state != 'SUCCESSFUL':
140140
raise AirflowException(f'Operation failed: result={result}')
141-
CloudDatastoreExportEntitiesLink.persist(
141+
StorageLink.persist(
142142
context=context,
143143
task_instance=self,
144-
output_url=result['response']['outputUrl'],
144+
uri=f"{self.bucket}/{result['response']['outputUrl'].split('/')[3]}",
145145
)
146146
return result
147147

β€Žairflow/providers/google/provider.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,6 @@ extra-links:
905905
- airflow.providers.google.cloud.operators.cloud_composer.CloudComposerEnvironmentsLink
906906
- airflow.providers.google.cloud.links.dataflow.DataflowJobLink
907907
- airflow.providers.google.cloud.links.datastore.CloudDatastoreImportExportLink
908-
- airflow.providers.google.cloud.links.datastore.CloudDatastoreExportEntitiesLink
909908
- airflow.providers.google.cloud.links.datastore.CloudDatastoreEntitiesLink
910909
- airflow.providers.google.common.links.storage.StorageLink
911910

0 commit comments

Comments
 (0)