Skip to content

Commit 632bd01

Browse files
authored
Fix MyPY errors for google.cloud.example_dags (#20232)
Part of #19891
1 parent e77c05f commit 632bd01

File tree

8 files changed

+17
-16
lines changed

8 files changed

+17
-16
lines changed

β€Žairflow/providers/google/cloud/example_dags/example_bigquery_operations.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,7 @@
193193
task_id="update_table",
194194
dataset_id=DATASET_NAME,
195195
table_id="test_table",
196-
fields=[
197-
{"name": "emp_name", "type": "STRING", "mode": "REQUIRED"},
198-
{"name": "salary", "type": "INTEGER", "mode": "NULLABLE"},
199-
],
196+
fields=["emp_name", "salary"],
200197
table_resource={
201198
"friendlyName": "Updated Table",
202199
"description": "Updated Table",

β€Žairflow/providers/google/cloud/example_dags/example_cloud_build.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import os
3232
from datetime import datetime
3333
from pathlib import Path
34+
from typing import Any, Dict
3435

3536
from future.backports.urllib.parse import urlparse
3637

@@ -99,7 +100,7 @@
99100
# [END howto_operator_gcp_create_build_from_storage_body]
100101

101102
# [START howto_operator_create_build_from_repo_body]
102-
create_build_from_repo_body = {
103+
create_build_from_repo_body: Dict[str, Any] = {
103104
"source": {"repo_source": {"repo_name": GCP_SOURCE_REPOSITORY_NAME, "branch_name": "main"}},
104105
"steps": [
105106
{

β€Žairflow/providers/google/cloud/example_dags/example_cloud_memorystore.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,9 @@
132132
task_id="failover-instance",
133133
location="europe-north1",
134134
instance=MEMORYSTORE_REDIS_INSTANCE_NAME_2,
135-
data_protection_mode=FailoverInstanceRequest.DataProtectionMode.LIMITED_DATA_LOSS,
135+
data_protection_mode=FailoverInstanceRequest.DataProtectionMode(
136+
FailoverInstanceRequest.DataProtectionMode.LIMITED_DATA_LOSS
137+
),
136138
project_id=GCP_PROJECT_ID,
137139
)
138140
# [END howto_operator_failover_instance]

β€Žairflow/providers/google/cloud/example_dags/example_functions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242

4343
import os
4444
from datetime import datetime
45+
from typing import Any, Dict
4546

4647
from airflow import models
4748
from airflow.providers.google.cloud.operators.functions import (
@@ -72,7 +73,7 @@
7273
# [END howto_operator_gcf_deploy_body]
7374

7475
# [START howto_operator_gcf_default_args]
75-
default_args = {'retries': 3}
76+
default_args: Dict[str, Any] = {'retries': 3}
7677
# [END howto_operator_gcf_default_args]
7778

7879
# [START howto_operator_gcf_deploy_variants]

β€Žairflow/providers/google/cloud/example_dags/example_mlengine.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"""
2222
import os
2323
from datetime import datetime
24-
from typing import Dict
24+
from typing import Any, Dict
2525

2626
from airflow import models
2727
from airflow.operators.bash import BashOperator
@@ -65,7 +65,7 @@
6565
tags=['example'],
6666
params={"model_name": MODEL_NAME},
6767
) as dag:
68-
hyperparams = {
68+
hyperparams: Dict[str, Any] = {
6969
'goal': 'MAXIMIZE',
7070
'hyperparameterMetricTag': 'metric1',
7171
'maxTrials': 30,

β€Žairflow/providers/google/cloud/operators/dataproc_metastore.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"""This module contains Google Dataproc Metastore operators."""
2020

2121
from time import sleep
22-
from typing import Dict, Optional, Sequence, Tuple, Union
22+
from typing import Collection, Dict, Optional, Sequence, Tuple, Union
2323

2424
from google.api_core.retry import Retry, exponential_sleep_generator
2525
from google.cloud.metastore_v1 import MetadataExport, MetadataManagementActivity
@@ -218,7 +218,7 @@ def __init__(
218218
project_id: str,
219219
region: str,
220220
service_id: str,
221-
metadata_import: MetadataImport,
221+
metadata_import: Union[MetadataImport, Dict[str, Collection[str]]],
222222
metadata_import_id: str,
223223
request_id: Optional[str] = None,
224224
retry: Optional[Retry] = None,

β€Žairflow/providers/google/cloud/operators/workflows.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import re
2020
import uuid
2121
from datetime import datetime, timedelta
22-
from typing import Dict, Optional, Sequence, Tuple, Union
22+
from typing import Dict, List, Optional, Sequence, Tuple, Union
2323

2424
import pytz
2525
from google.api_core.exceptions import AlreadyExists
@@ -179,7 +179,7 @@ def __init__(
179179
workflow_id: str,
180180
location: str,
181181
project_id: Optional[str] = None,
182-
update_mask: Optional[FieldMask] = None,
182+
update_mask: Optional[Union[FieldMask, Dict[str, List[str]]]] = None,
183183
retry: Optional[Retry] = None,
184184
timeout: Optional[float] = None,
185185
metadata: Optional[Sequence[Tuple[str, str]]] = None,

β€Žairflow/providers/google/cloud/sensors/datafusion.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# specific language governing permissions and limitations
1717
# under the License.
1818
"""This module contains a Google Cloud Data Fusion sensors."""
19-
from typing import Optional, Sequence, Set, Union
19+
from typing import Iterable, Optional, Sequence, Union
2020

2121
from airflow.exceptions import AirflowException
2222
from airflow.providers.google.cloud.hooks.datafusion import DataFusionHook
@@ -69,10 +69,10 @@ def __init__(
6969
self,
7070
pipeline_name: str,
7171
pipeline_id: str,
72-
expected_statuses: Set[str],
72+
expected_statuses: Iterable[str],
7373
instance_name: str,
7474
location: str,
75-
failure_statuses: Optional[Set[str]] = None,
75+
failure_statuses: Optional[Iterable[str]] = None,
7676
project_id: Optional[str] = None,
7777
namespace: str = "default",
7878
gcp_conn_id: str = 'google_cloud_default',

0 commit comments

Comments
 (0)