Skip to content

Commit babc425

Browse files
authored
Fixes statich check failures (#17218)
Fixes static check failures after #17160 was merged with some failing status of main.
1 parent 04ca4ec commit babc425

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

β€Žairflow/providers/google/CHANGELOG.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ Breaking changes
2727
* ``Updated GoogleAdsHook to support newer API versions after google deprecated v5. Google Ads v8 is the new default API. (#17111)``
2828

2929
.. warning:: The underlying google-ads library had breaking changes.
30-
31-
Previously the google ads library returned data as native protobuf messages. Now it returns data as proto-plus objects that behave more like conventional Python objects.
3230

33-
To preserve compatibility the hook's `search()` converts the data back to native protobuf before returning it. Your existing operators *should* work as before, but due to the urgency of the v5 API being deprecated it was not tested too thoroughly. Therefore you should carefully evaluate your operator and hook functionality with this new version.
31+
Previously the google ads library returned data as native protobuf messages. Now it returns data as proto-plus objects that behave more like conventional Python objects.
3432

35-
In order to use the API's new proto-plus format, you can use the `search_proto_plus()` method.
33+
To preserve compatibility the hook's ``search()`` converts the data back to native protobuf before returning it. Your existing operators *should* work as before, but due to the urgency of the v5 API being deprecated it was not tested too thoroughly. Therefore you should carefully evaluate your operator and hook functionality with this new version.
3634

37-
For more information, please consult `google-ads migration document <https://developers.google.com/google-ads/api/docs/client-libs/python/library-version-10>`__:
35+
In order to use the API's new proto-plus format, you can use the ``search_proto_plus()`` method.
36+
37+
For more information, please consult `google-ads migration document <https://developers.google.com/google-ads/api/docs/client-libs/python/library-version-10>`__:
3838

3939

4040
Features

β€Žairflow/providers/google/ads/hooks/ads.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ def list_accessible_customers(self) -> List[str]:
164164
@cached_property
165165
def _get_service(self) -> Resource:
166166
"""Connects and authenticates with the Google Ads API using a service account"""
167-
168167
client = self._get_client
169168
return client.get_service("GoogleAdsService", version=self.api_version)
170169

0 commit comments

Comments
 (0)