Bump Pylint to 2.5.3 (#9294)

Author: kaxil

.github/workflows/ci.yml

@@ -57,7 +57,7 @@ jobs:
       - name: Cache pre-commit env
         uses: actions/cache@v2
         env:
-          cache-name: cache-pre-commit-v2
+          cache-name: cache-pre-commit-v3
         with:
           path: ~/.cache/pre-commit
           key: ${{ env.cache-name }}-${{ github.job }}-${{ hashFiles('.pre-commit-config.yaml') }}
@@ -90,7 +90,7 @@ jobs:
       - name: Cache pre-commit env
         uses: actions/cache@v2
         env:
-          cache-name: cache-pre-commit
+          cache-name: cache-pre-commit-v1
         with:
           path: ~/.cache/pre-commit
           key: ${{ env.cache-name }}-${{ github.job }}-${{ hashFiles('.pre-commit-config.yaml') }}

airflow/api_connexion/schemas/connection_schema.py

@@ -43,7 +43,7 @@ class Meta:
     # We will be able to remove this when we upgrade to marshmallow 3.
     # To remove it, we would need to set unknown=EXCLUDE in Meta
     @validates_schema(pass_original=True)
-    def check_unknown_fields(self, data, original_data):
+    def check_unknown_fields(self, data, original_data):    # pylint: disable=unused-argument
         """ Validates unknown field """
         unknown = set(original_data) - set(self.fields)
         if unknown:

airflow/executors/debug_executor.py

@@ -49,7 +49,7 @@ def __init__(self):
         self.tasks_params: Dict[TaskInstanceKeyType, Dict[str, Any]] = {}
         self.fail_fast = conf.getboolean("debug", "fail_fast")
 
-    def execute_async(self, *args, **kwargs) -> None:
+    def execute_async(self, *args, **kwargs) -> None:   # pylint: disable=signature-differs
         """
         The method is replaced by custom trigger_task implementation.
         """

airflow/executors/local_executor.py

@@ -153,13 +153,13 @@ def start(self) -> None:
             self.executor.workers_used = 0
             self.executor.workers_active = 0
 
+        # pylint: disable=unused-argument # pragma: no cover
         # noinspection PyUnusedLocal
         def execute_async(self,
                           key: TaskInstanceKeyType,
                           command: CommandType,
                           queue: Optional[str] = None,
-                          executor_config: Optional[Any] = None) -> None:  \
-                # pylint: disable=unused-argument # pragma: no cover
+                          executor_config: Optional[Any] = None) -> None:
             """
             Executes task asynchronously.
 
@@ -175,6 +175,7 @@ def execute_async(self,
             self.executor.workers_active += 1
             local_worker.start()
 
+        # pylint: enable=unused-argument # pragma: no cover
         def sync(self) -> None:
             """
             Sync will get called periodically by the heartbeat method.
@@ -224,12 +225,13 @@ def start(self) -> None:
                 worker.start()
 
         # noinspection PyUnusedLocal
-        def execute_async(self,
-                          key: TaskInstanceKeyType,
-                          command: CommandType,
-                          queue: Optional[str] = None,
-                          executor_config: Optional[Any] = None) -> None: \
-                # pylint: disable=unused-argument # pragma: no cover
+        def execute_async(
+            self,
+            key: TaskInstanceKeyType,
+            command: CommandType,
+            queue: Optional[str] = None,  # pylint: disable=unused-argument
+            executor_config: Optional[Any] = None  # pylint: disable=unused-argument
+        ) -> None:
             """
             Executes task asynchronously.
 

airflow/jobs/local_task_job.py

@@ -73,11 +73,14 @@ def __init__(
     def _execute(self):
         self.task_runner = get_task_runner(self)
 
+        # pylint: disable=unused-argument
         def signal_handler(signum, frame):
             """Setting kill signal handler"""
             self.log.error("Received SIGTERM. Terminating subprocesses")
             self.on_kill()
             raise AirflowException("LocalTaskJob received SIGTERM signal")
+
+        # pylint: enable=unused-argument
         signal.signal(signal.SIGTERM, signal_handler)
 
         if not self.task_instance.check_and_change_state_before_execution(

airflow/models/pool.py

@@ -50,7 +50,7 @@ class Pool(Base):
     DEFAULT_POOL_NAME = 'default_pool'
 
     def __repr__(self):
-        return self.pool
+        return str(self.pool)    # pylint: disable=E0012
 
     @staticmethod
     @provide_session

airflow/providers/google/cloud/example_dags/example_bigquery_dts.py

@@ -97,7 +97,7 @@
         requested_run_time={"seconds": int(time.time() + 60)},
     )
     run_id = (
-        "{{ task_instance.xcom_pull('gcp_bigquery_start_transfer', " "key='run_id') }}"
+        "{{ task_instance.xcom_pull('gcp_bigquery_start_transfer', key='run_id') }}"
     )
     # [END howto_bigquery_start_transfer]
 

airflow/providers/google/cloud/hooks/functions.py

@@ -145,8 +145,9 @@ def upload_function_zip(self, location: str, zip_path: str, project_id: str) ->
         :return: The upload URL that was returned by generateUploadUrl method.
         :rtype: str
         """
+        # pylint: disable=no-member # noqa
         response = \
-            self.get_conn().projects().locations().functions().generateUploadUrl(  # pylint: disable=no-member # noqa
+            self.get_conn().projects().locations().functions().generateUploadUrl(
                 parent=self._full_location(project_id, location)
             ).execute(num_retries=self.num_retries)
 

airflow/providers/google/cloud/hooks/gcs.py

@@ -273,7 +273,7 @@ def provide_file(
         self,
         bucket_name: Optional[str] = None,
         object_name: Optional[str] = None,
-        object_url: Optional[str] = None
+        object_url: Optional[str] = None    # pylint: disable=unused-argument
     ):
         """
         Downloads the file to a temporary directory and returns a file handle

airflow/sensors/base_sensor_operator.py

@@ -199,8 +199,7 @@ def mode_getter(_):
 
         def mode_setter(_, value):
             if value != 'poke':
-                raise ValueError(
-                    f"cannot set mode to 'poke'.")
+                raise ValueError("cannot set mode to 'poke'.")
 
         if not issubclass(cls_type, BaseSensorOperator):
             raise ValueError(f"poke_mode_only decorator should only be "