Replacing non-attribute template_fields for BigQueryToMsSqlOperator (#19052)

josh-fell · web-flow · commit d9192a55baca · 2021-10-22T20:18:10.000+02:00
* Replacing non-attribute template_fields for BigQueryToMsSqlOperator

* Updating source_project_dataset_table arg in example DAG
diff --git a/airflow/providers/google/cloud/example_dags/example_bigquery_to_mssql.py b/airflow/providers/google/cloud/example_dags/example_bigquery_to_mssql.py
@@ -44,7 +44,7 @@
 ) as dag:
     bigquery_to_mssql = BigQueryToMsSqlOperator(
         task_id="bigquery_to_mssql",
-        source_project_dataset_table=f'{DATASET_NAME}.{TABLE}',
+        source_project_dataset_table=f'{PROJECT_ID}.{DATASET_NAME}.{TABLE}',
         mssql_table=destination_table,
         replace=False,
     )
diff --git a/airflow/providers/google/cloud/transfers/bigquery_to_mssql.py b/airflow/providers/google/cloud/transfers/bigquery_to_mssql.py
@@ -82,12 +82,7 @@ class BigQueryToMsSqlOperator(BaseOperator):
     :type impersonation_chain: Union[str, Sequence[str]]
     """
 
-    template_fields = (
-        'dataset_id',
-        'table_id',
-        'mssql_table',
-        'impersonation_chain',
-    )
+    template_fields = ('source_project_dataset_table', 'mssql_table', 'impersonation_chain')
 
     def __init__(
         self,

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@`
`44`	`44`	`) as dag:`
`45`	`45`	`bigquery_to_mssql = BigQueryToMsSqlOperator(`
`46`	`46`	`task_id="bigquery_to_mssql",`
`47`		`- source_project_dataset_table=f'{DATASET_NAME}.{TABLE}',`
	`47`	`+ source_project_dataset_table=f'{PROJECT_ID}.{DATASET_NAME}.{TABLE}',`
`48`	`48`	`mssql_table=destination_table,`
`49`	`49`	`replace=False,`
`50`	`50`	`)`