Skip to content

Commit e315900

Browse files
authored
specifying project id when calling wait_for_operation in delete/create cluster (#26418)
* specifying project id when calling wait_for_operation in delete/create cluster
1 parent 0bca962 commit e315900

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

β€Žairflow/providers/google/cloud/hooks/kubernetes_engine.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def delete_cluster(
180180
retry=retry,
181181
timeout=timeout,
182182
)
183-
resource = self.wait_for_operation(resource)
183+
resource = self.wait_for_operation(resource, project_id)
184184
# Returns server-defined url for the resource
185185
return resource.self_link
186186
except NotFound as error:
@@ -234,7 +234,7 @@ def create_cluster(
234234
retry=retry,
235235
timeout=timeout,
236236
)
237-
resource = self.wait_for_operation(resource)
237+
resource = self.wait_for_operation(resource, project_id)
238238

239239
return resource.target_link
240240
except AlreadyExists as error:

β€Žtests/providers/google/cloud/hooks/test_kubernetes_engine.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def test_delete_cluster(self, wait_mock):
7373
retry=retry_mock,
7474
timeout=timeout_mock,
7575
)
76-
wait_mock.assert_called_once_with(client_delete.return_value)
76+
wait_mock.assert_called_once_with(client_delete.return_value, TEST_GCP_PROJECT_ID)
7777

7878
@mock.patch(GKE_STRING.format("GKEHook.log"))
7979
@mock.patch(GKE_STRING.format("GKEHook.wait_for_operation"))
@@ -130,7 +130,7 @@ def test_create_cluster_proto(self, wait_mock):
130130
retry=retry_mock,
131131
timeout=timeout_mock,
132132
)
133-
wait_mock.assert_called_once_with(client_create.return_value)
133+
wait_mock.assert_called_once_with(client_create.return_value, TEST_GCP_PROJECT_ID)
134134

135135
@mock.patch(GKE_STRING.format("Cluster.from_json"))
136136
@mock.patch(GKE_STRING.format("GKEHook.wait_for_operation"))
@@ -151,7 +151,7 @@ def test_create_cluster_dict(self, wait_mock, convert_mock):
151151
retry=retry_mock,
152152
timeout=timeout_mock,
153153
)
154-
wait_mock.assert_called_once_with(client_create.return_value)
154+
wait_mock.assert_called_once_with(client_create.return_value, TEST_GCP_PROJECT_ID)
155155

156156
@mock.patch(GKE_STRING.format("GKEHook.wait_for_operation"))
157157
def test_create_cluster_error(self, wait_mock):

0 commit comments

Comments
 (0)