Fix inconsistency of getDocument() variants (Issue #168)

Author: mpv1989

ChangeLog

@@ -1,6 +1,7 @@
 v4.3.3 (2018-xx-xx)
 ---------------------------
 * added AqlQueryOptions.memoryLimit(Long)
+* fixed inconsistency of getDocument() variants (Issue #168)
 
 v4.3.2 (2017-11-30)
 ---------------------------

src/main/java/com/arangodb/ArangoCollection.java

@@ -208,15 +208,7 @@ public DocumentImportEntity importDocuments(final String values, final DocumentI
 	 * @throws ArangoDBException
 	 */
 	public <T> T getDocument(final String key, final Class<T> type) throws ArangoDBException {
-		executor.validateDocumentKey(key);
-		try {
-			return executor.execute(getDocumentRequest(key, new DocumentReadOptions()), type);
-		} catch (final ArangoDBException e) {
-			if (LOGGER.isDebugEnabled()) {
-				LOGGER.debug(e.getMessage(), e);
-			}
-			return null;
-		}
+		return getDocument(key, type, new DocumentReadOptions());
 	}
 
 	/**

src/test/java/com/arangodb/ArangoCollectionTest.java

@@ -224,6 +224,19 @@ public void getDocumentNotFound() {
 		assertThat(document, is(nullValue()));
 	}
 
+	@Test
+	public void getDocumentNotFoundOptionsDefault() {
+		final BaseDocument document = db.collection(COLLECTION_NAME).getDocument("no", BaseDocument.class,
+			new DocumentReadOptions());
+		assertThat(document, is(nullValue()));
+	}
+
+	@Test
+	public void getDocumentNotFoundOptionsNull() {
+		final BaseDocument document = db.collection(COLLECTION_NAME).getDocument("no", BaseDocument.class, null);
+		assertThat(document, is(nullValue()));
+	}
+
 	@Test(expected = ArangoDBException.class)
 	public void getDocumentNotFoundThrowException() {
 		db.collection(COLLECTION_NAME).getDocument("no", BaseDocument.class,