Skip to content

Conversation

niko-achilles
Copy link
Contributor

Description of your changes

bringYourOwnFormatterClass code is back.

How to verify this change

see in the docs , Logger, section : Custom Log formatter (Bring Your Own Formatter), code snippet for
This is how the MyCompanyLogFormatter (dummy name) would look like:
...

Related issues, RFCs

Issue number: #1253

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi linked an issue Jan 17, 2023 that may be closed by this pull request
1 task
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2023
@dreamorosi dreamorosi merged commit fdbba32 into aws-powertools:main Jan 17, 2023
@dreamorosi dreamorosi added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jan 17, 2023
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2023
@niko-achilles niko-achilles deleted the logger-code-snippets branch January 17, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Custom Log Formatter Example disappeared from documentation
2 participants