Create CodeApi and separate the API methods

Author: EhabY

src/agentMetadataHelper.ts

@@ -4,8 +4,8 @@ import {
 	AgentMetadataEvent,
 	AgentMetadataEventSchemaArray,
 	errToStr,
-} from "./api-helper";
-import { CoderWebSocketClient } from "./websocket/webSocketClient";
+} from "./api/api-helper";
+import { CodeApi } from "./api/codeApi";
 
 export type AgentMetadataWatcher = {
 	onChange: vscode.EventEmitter<null>["event"];
@@ -20,9 +20,9 @@ export type AgentMetadataWatcher = {
  */
 export function createAgentMetadataWatcher(
 	agentId: WorkspaceAgent["id"],
-	webSocketClient: CoderWebSocketClient,
+	client: CodeApi,
 ): AgentMetadataWatcher {
-	const socket = webSocketClient.watchAgentMetadata(agentId);
+	const socket = client.watchAgentMetadata(agentId);
 
 	let disposed = false;
 	const onChange = new vscode.EventEmitter<null>();

src/api.ts

@@ -7,6 +7,9 @@ import {
 import { ErrorEvent } from "eventsource";
 import { z } from "zod";
 
+/**
+ * Convert various error types to readable strings
+ */
 export function errToStr(
 	error: unknown,
 	def: string = "No error message provided",
@@ -27,6 +30,13 @@ export function errToStr(
 	return def;
 }
 
+/**
+ * Create workspace owner/name identifier
+ */
+export function createWorkspaceIdentifier(workspace: Workspace): string {
+	return `${workspace.owner_name}/${workspace.name}`;
+}
+
 export function extractAllAgents(
 	workspaces: readonly Workspace[],
 ): WorkspaceAgent[] {

src/api-helper.ts renamed to src/api/api-helper.ts

@@ -0,0 +1,50 @@
+import fs from "fs";
+import { ProxyAgent } from "proxy-agent";
+import { type WorkspaceConfiguration } from "vscode";
+import { getProxyForUrl } from "../proxy";
+import { expandPath } from "../util";
+
+/**
+ * Return whether the API will need a token for authorization.
+ * If mTLS is in use (as specified by the cert or key files being set) then
+ * token authorization is disabled. Otherwise, it is enabled.
+ */
+export function needToken(cfg: WorkspaceConfiguration): boolean {
+	const certFile = expandPath(
+		String(cfg.get("coder.tlsCertFile") ?? "").trim(),
+	);
+	const keyFile = expandPath(String(cfg.get("coder.tlsKeyFile") ?? "").trim());
+	return !certFile && !keyFile;
+}
+
+/**
+ * Create a new HTTP agent based on the current VS Code settings.
+ * Configures proxy, TLS certificates, and security options.
+ */
+export function createHttpAgent(cfg: WorkspaceConfiguration): ProxyAgent {
+	const insecure = Boolean(cfg.get("coder.insecure"));
+	const certFile = expandPath(
+		String(cfg.get("coder.tlsCertFile") ?? "").trim(),
+	);
+	const keyFile = expandPath(String(cfg.get("coder.tlsKeyFile") ?? "").trim());
+	const caFile = expandPath(String(cfg.get("coder.tlsCaFile") ?? "").trim());
+	const altHost = expandPath(String(cfg.get("coder.tlsAltHost") ?? "").trim());
+
+	return new ProxyAgent({
+		// Called each time a request is made.
+		getProxyForUrl: (url: string) => {
+			return getProxyForUrl(
+				url,
+				cfg.get("http.proxy"),
+				cfg.get("coder.proxyBypass"),
+			);
+		},
+		cert: certFile === "" ? undefined : fs.readFileSync(certFile),
+		key: keyFile === "" ? undefined : fs.readFileSync(keyFile),
+		ca: caFile === "" ? undefined : fs.readFileSync(caFile),
+		servername: altHost === "" ? undefined : altHost,
+		// rejectUnauthorized defaults to true, so we need to explicitly set it to
+		// false if we want to allow self-signed certificates.
+		rejectUnauthorized: !insecure,
+	});
+}