fix: use app.whenReady and remove delay race for electron startup#15075
Merged
Conversation
This change fixes an issue that caused the startup to be delayed by 500ms.
We used `app.on('ready')` without checking `app.isReady()`, however the
'ready' event may already have fired at this point and thus we never
resolved the Promise waiting for it.
Using `app.whenReady` fixes this and now that Promise resolves before
the delay expires.
Related links:
https://www.electronjs.org/docs/api/app#event-ready
https://www.electronjs.org/docs/api/app#appwhenready
Contributor
|
Thanks for taking the time to open a PR!
|
|
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
cypress opencypress open/cypress run
cypress open/cypress run
bahmutov
approved these changes
Feb 15, 2021
Contributor
bahmutov
left a comment
There was a problem hiding this comment.
local Cypress still works, and CI tests pass, nice
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an issue that caused the startup to be delayed by 500ms.
We used
app.on('ready')without checkingapp.isReady(), however the'ready' event may already have fired at this point and thus we never
resolved the Promise waiting for it.
Using
app.whenReadyfixes this and now that Promise resolves beforethe delay expires.
Related links:
https://www.electronjs.org/docs/api/app#event-ready
https://www.electronjs.org/docs/api/app#appwhenready
User facing changelog
cypress openandcypress run.Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?