refactor(component-testing): simplify vue mount by elevatebart · Pull Request #15275 · cypress-io/cypress · GitHub

elevatebart · 2021-03-01T16:21:54Z

Closes CT-367

User facing changelog

Fixes some of the memory leaks in with @cypress/vue

Additional details

Avoid recreating the root element at each test
Make sure we properly destroy the vue instance after each iteration

This might fix some issues with devtools

PR Tasks

Has the original issue or this PR been tagged with a release in ZenHub?

cypress-bot · 2021-03-01T16:21:55Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

lmiller1990 · 2021-03-08T00:32:57Z

We could use the feature that is built in to test utils: https://vue-test-utils.vuejs.org/api/#enableautodestroy-hook

lmiller1990

I think we could consider using the version built into test utils: We could use the feature that is built in to test utils: https://vue-test-utils.vuejs.org/api/#enableautodestroy-hook

elevatebart · 2021-03-08T14:49:06Z

@lmiller1990 I do not think we can put anything in afterEach without reaching for a support file.
It would uselessly complicate the installation process.

Where were you thinking we call this enableAutoDestroy function?

elevatebart · 2021-03-08T15:04:49Z

I understand after looking at your vite PR what you mean.
Tell me if my implementation seems fine.

cypress · 2021-03-08T15:26:29Z

Test summary

9392 • 0 • 119 • 3 • 1

Run details


Project	cypress
Status	Passed
Commit	`b7a380b`
Started	Mar 19, 2021 12:23 AM
Ended	Mar 19, 2021 12:34 AM
Duration	10:46 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

Flakiness

	cypress/integration/retries.ui.spec.js		1
1	runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

JessicaSachs

This looks okay to me. It's an improvement on where we currently are. There are some fundamental issues with how we are cleaning up, but those will be addressed when we refactor these to use Cypress's internal events.

lmiller1990

✅

JessicaSachs

Manually tested this. It's looking good.

- Avoid recreating the root element at each test - Make sure we properly destroy the vue instance after each iteration

cypress-bot · 2021-04-05T22:40:51Z

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

elevatebart requested review from JessicaSachs and dmtrKovalenko March 1, 2021 16:21

dmtrKovalenko reviewed Mar 1, 2021

View reviewed changes

Comment thread npm/vue/src/index.ts Outdated

dmtrKovalenko reviewed Mar 1, 2021

View reviewed changes

Comment thread npm/vue/src/index.ts Outdated

dmtrKovalenko previously approved these changes Mar 5, 2021

View reviewed changes

elevatebart dismissed dmtrKovalenko’s stale review via 4264ec8 March 5, 2021 19:10

lmiller1990 self-requested a review March 8, 2021 00:33

lmiller1990 suggested changes Mar 8, 2021

View reviewed changes

lmiller1990 previously approved these changes Mar 11, 2021

View reviewed changes

Comment thread npm/vue/src/index.ts Outdated

JessicaSachs previously approved these changes Mar 13, 2021

View reviewed changes

elevatebart dismissed stale reviews from JessicaSachs and lmiller1990 via aae78cb March 15, 2021 18:49

lmiller1990 self-requested a review March 15, 2021 23:25

lmiller1990 previously approved these changes Mar 15, 2021

View reviewed changes

elevatebart dismissed lmiller1990’s stale review via ef3c490 March 16, 2021 21:58

JessicaSachs previously approved these changes Mar 18, 2021

View reviewed changes

lmiller1990 dismissed JessicaSachs’s stale review via e3d152b March 18, 2021 05:42

lmiller1990 force-pushed the refact/simplify-vue-mount branch from e3d152b to 46f0959 Compare March 18, 2021 06:00

lmiller1990 dismissed a stale review via 5cf5ad3 March 18, 2021 08:00

elevatebart force-pushed the refact/simplify-vue-mount branch from 5cf5ad3 to e6adfa9 Compare March 18, 2021 15:13

refactor: simplify vue mount

e8297be

- Avoid recreating the root element at each test - Make sure we properly destroy the vue instance after each iteration

elevatebart force-pushed the refact/simplify-vue-mount branch from f03b6e1 to e8297be Compare March 18, 2021 19:29

tests: fix remotepizza test

3e9a88d

JessicaSachs previously approved these changes Mar 18, 2021

View reviewed changes

Merge branch 'develop' into refact/simplify-vue-mount

637eb78

JessicaSachs and others added 2 commits March 18, 2021 19:53

Merge branch 'develop' into refact/simplify-vue-mount

225397d

fix: bring back support file to avoid breakage in API

b7a380b

elevatebart dismissed JessicaSachs’s stale review via b7a380b March 19, 2021 00:13

lmiller1990 self-requested a review March 19, 2021 00:14

JessicaSachs approved these changes Mar 19, 2021

View reviewed changes

lmiller1990 approved these changes Mar 19, 2021

View reviewed changes

JessicaSachs merged commit a12b72b into develop Mar 19, 2021

elevatebart deleted the refact/simplify-vue-mount branch March 19, 2021 00:47

dmtrKovalenko mentioned this pull request Mar 23, 2021

fix(@cypress/react): Devtools unpredictable resets #15612

Merged

cypress-bot Bot locked as resolved and limited conversation to collaborators Apr 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(component-testing): simplify vue mount#15275

refactor(component-testing): simplify vue mount#15275
JessicaSachs merged 5 commits into
developfrom
refact/simplify-vue-mount

elevatebart commented Mar 1, 2021 •

edited

Loading

Uh oh!

cypress-bot Bot commented Mar 1, 2021

Uh oh!

Uh oh!

Uh oh!

lmiller1990 commented Mar 8, 2021

Uh oh!

lmiller1990 left a comment

Uh oh!

elevatebart commented Mar 8, 2021

Uh oh!

elevatebart commented Mar 8, 2021

Uh oh!

cypress Bot commented Mar 8, 2021 •

edited

Loading

Uh oh!

Uh oh!

JessicaSachs left a comment

Uh oh!

lmiller1990 left a comment

Uh oh!

JessicaSachs left a comment

Uh oh!

cypress-bot Bot commented Apr 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

elevatebart commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User facing changelog

Additional details

PR Tasks

Uh oh!

cypress-bot Bot commented Mar 1, 2021

Uh oh!

Uh oh!

Uh oh!

lmiller1990 commented Mar 8, 2021

Uh oh!

lmiller1990 left a comment

Choose a reason for hiding this comment

Uh oh!

elevatebart commented Mar 8, 2021

Uh oh!

elevatebart commented Mar 8, 2021

Uh oh!

cypress Bot commented Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test summary

Run details

Flakiness

Uh oh!

Uh oh!

JessicaSachs left a comment

Choose a reason for hiding this comment

Uh oh!

lmiller1990 left a comment

Choose a reason for hiding this comment

Uh oh!

JessicaSachs left a comment

Choose a reason for hiding this comment

Uh oh!

cypress-bot Bot commented Apr 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

elevatebart commented Mar 1, 2021 •

edited

Loading

cypress Bot commented Mar 8, 2021 •

edited

Loading