feat: Allow type() and click() to select an element inside contenteditable.#9066
Merged
Conversation
Contributor
|
Thanks for taking the time to open a PR!
|
Contributor
Author
|
flaky failure. |
This was referenced Nov 17, 2020
Andarist
reviewed
Aug 27, 2021
| const finalCoords = getCoordinatesForEl(cy, $el, options) | ||
| let finalEl | ||
|
|
||
| // When a contenteditable element is selected, we don't go deeper, |
Contributor
There was a problem hiding this comment.
@sainthkh would it be more accurate to say that "when a host contenteditable element is selected"? It feels a little bit like the comment doesn't match the condition because inner elements can still be contenteditable (.isContentEditable === true) but they won't pass this test here
Contributor
Author
There was a problem hiding this comment.
I agree. It seems that When a selected element is contenteditable can better describe the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
When
cy.type()andcy.click()were used against an element insidecontenteditable, it only worked with the rootcontenteditableelement. With this PR, this behavior is fixed. Users can freely work with elements inside contenteditable.Additional details
contenteditable, it is sometimes necessary to work with elements inside it.type()andclick()changed slightly.runAllCheckinactionability.jsto ignore elements insidecontenteditable.How has the user experience changed?
PR Tasks
cypress-documentation? => Add this to 6.0 changes doc.