fix/nan-fcd-parquet#18023
Open
aminissn wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@behrisch based on your comment earlier today, I added an option so that user can decide to write empty rows in the output to have a behavior similar to xml output writer |
Contributor
|
Great, but I think this option would be useful for the standard fcd output too, so no need to limit it to parquet |
Contributor
Author
I wasn't sure if you like that part of the code to change, due to backward compatibility or parsing functions. But if you think it won't cause any issues, I made the changes in my last commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.