build: add opt-in IWYU support and clean up includes#63
Conversation
Add a CMake-controlled IWYU path and a dedicated task so include hygiene can be checked locally without affecting default builds. Keep the workflow easy to rerun from a clean build tree.
There was a problem hiding this comment.
Code Review
This pull request implements project-wide "Include What You Use" (IWYU) integration, including CMake support, Taskfile commands, and extensive header cleanup across the library, examples, and tests. It also introduces a mechanism to enable strict compiler warnings and refactors internal logic, such as improving index tracking in the read-only manager using std::optional. Feedback focuses on the migration of the clang-format Docker image to a personal repository, which poses a maintenance risk, and an unnecessary change to a loop counter in the inflights test that introduces signed/unsigned comparison issues.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 62.33% 62.33%
=======================================
Files 58 58
Lines 8491 8489 -2
Branches 1425 1425
=======================================
- Hits 5293 5292 -1
+ Misses 2588 2586 -2
- Partials 610 611 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
task iwyuandtask testpass