Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.0
Choose a base ref
...
head repository: golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.0
Choose a head ref
  • 3 commits
  • 11 files changed
  • 3 contributors

Commits on Sep 26, 2023

  1. singleflight: add panicError.Unwrap method

    Currently when singleflight recovers from a panic, it wraps it with the private
    error type panicError. This change adds an `Unwrap` method to panicError to
    allow wrapped errors to be returned.
    
    Updates golang/go#62511
    
    Change-Id: Ia510ad7d5881207ef71f9eb89c1766835af19b6b
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/526171
    Auto-Submit: Bryan Mills <bcmills@google.com>
    Reviewed-by: Than McIntosh <thanm@google.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    ewohltman authored and gopherbot committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    22ba207 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. all: update go directive to 1.18

    Done with:
    
    go get go@1.18
    go mod tidy
    go fix ./...
    
    Using go1.21.3.
    
    While here, simplify package syncmap by taking advantage of knowing
    that all supported Go versions will have the go1.9 build constraint
    satisfied.
    
    For golang/go#60268.
    
    Change-Id: Ic0f24ab13ada6839573e55beee5516c1a6c7f3cc
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/534220
    Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    dmitshur authored and gopherbot committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    10739b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. errgroup: add reference to sync.WaitGroup

    Add doc link to sync.WaitGroup in the package documentation.
    
    Rationale:
    The reference to sync.WaitGroup might be obvious to the authors of this
    package, but it wasn't to me, so despites I had seen this package
    multiple times I had never made the link to sync.WaitGroup. So when
    playing with WaitGroup I was missing remembering about errgroup.
    In hope this will help others as well as my future self.
    
    Change-Id: I2c56976958ad9ab94c1596c96fa86c00dd73d2fb
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/538335
    Reviewed-by: Bryan Mills <bcmills@google.com>
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    Auto-Submit: Bryan Mills <bcmills@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    dolmen authored and gopherbot committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    59c1ca1 View commit details
    Browse the repository at this point in the history
Loading