Skip to content

Commit aa2f11e

Browse files
committed
chore: refactors / addresses pr comments
1 parent 5fbb0b2 commit aa2f11e

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

β€Žgoogle-cloud-spanner/src/main/java/com/google/cloud/spanner/BackupInfo.javaβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public Builder setExpireTime(Timestamp expireTime) {
100100

101101
@Override
102102
public Builder setVersionTime(Timestamp versionTime) {
103-
this.versionTime = Preconditions.checkNotNull(versionTime);
103+
this.versionTime = versionTime;
104104
return this;
105105
}
106106

β€Žgoogle-cloud-spanner/src/main/java/com/google/cloud/spanner/Database.javaβ€Ž

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,16 +119,13 @@ public OperationFuture<Backup, CreateBackupMetadata> backup(Backup backup) {
119119
backup.getInstanceId().equals(getId().getInstanceId()),
120120
"The instance of the backup must be equal to the instance of this database.");
121121

122-
final BackupInfo.Builder backupBuilder =
122+
return dbClient.createBackup(
123123
dbClient
124124
.newBackupBuilder(backup.getId())
125125
.setDatabase(getId())
126-
.setExpireTime(backup.getExpireTime());
127-
if (backup.getVersionTime() != null) {
128-
backupBuilder.setVersionTime(backup.getVersionTime());
129-
}
130-
131-
return dbClient.createBackup(backupBuilder.build());
126+
.setExpireTime(backup.getExpireTime())
127+
.setVersionTime(backup.getVersionTime())
128+
.build());
132129
}
133130

134131
/**

0 commit comments

Comments
 (0)