Skip to content

chore!: migrate to node 18 #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 16, 2025
Merged

chore!: migrate to node 18 #1458

merged 14 commits into from
Apr 16, 2025

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Apr 3, 2025 β€’
edited
Loading

Migration tasks for personal tracking:

  • Run migration scripts (removes kokoro files, update packages, update post processing, etc)
  • Format files with new eslint rules
  • Solve security issues
  • Update or remove deps as we move to Node 18
  • Resolve issues with test and system-tests
    • "should insert rows via stream" system test is not passing due to some issues with duplexify + util.makeWritableStream. It seems like BigQuery job configuration is not being passed properly Issue with Teeny request was not supporting fetch Headers classes and failing to set ContentType header for multipart upload. Fixed on feat: support fetch Headers class teeny-request#359

Towards internal b/397525047

@alvarowolfx alvarowolfx requested a review from leahecole April 3, 2025 16:57
@alvarowolfx alvarowolfx requested review from a team as code owners April 3, 2025 16:57
@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Apr 3, 2025 β€’
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Apr 3, 2025
@leahecole leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 4, 2025
@alvarowolfx alvarowolfx mentioned this pull request Apr 7, 2025
Merged
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2025
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2025
@alvarowolfx alvarowolfx removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 8, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 8, 2025
@alvarowolfx alvarowolfx mentioned this pull request Apr 9, 2025
Closed
@alvarowolfx alvarowolfx merged commit 6cd706b into main Apr 16, 2025
18 checks passed
@alvarowolfx alvarowolfx deleted the migrate-node-18 branch April 16, 2025 18:37
@release-please release-please bot mentioned this pull request Apr 16, 2025
Merged
@alvarowolfx alvarowolfx mentioned this pull request Apr 17, 2025
Closed
This was referenced May 6, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvarowolfx @leahecole @yoshi-kokoro