Skip to content

fix: dataframe sort_values Series input now raises keyerror. #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix: dataframe sort_values Series input now raises keyerror. #1285

merged 2 commits into from
Jan 14, 2025

Conversation

Genesis929
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> πŸ¦•

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 14, 2025
@Genesis929 Genesis929 changed the title fix: dataframe sort_values Series input keyerror. fix: dataframe sort_values Series input now raises keyerror. Jan 14, 2025
@Genesis929 Genesis929 requested a review from tswast January 14, 2025 00:34
@Genesis929 Genesis929 marked this pull request as ready for review January 14, 2025 00:34
@Genesis929 Genesis929 requested review from a team as code owners January 14, 2025 00:34
@Genesis929 Genesis929 merged commit 5a2731b into main Jan 14, 2025
22 checks passed
@Genesis929 Genesis929 deleted the sort_values_fix_huanc branch January 14, 2025 21:59
@release-please release-please bot mentioned this pull request Jan 14, 2025
Merged
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
@Genesis929 @shuoweil
fix: dataframe sort_values Series input keyerror. (#1285)
ee5df79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees

@junyazhang junyazhang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Genesis929 @chelsea-lin @junyazhang