Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 8, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> πŸ¦•

@tswast tswast requested review from a team as code owners April 8, 2025 22:22
@tswast tswast requested a review from shobsi April 8, 2025 22:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 8, 2025
@tswast
Copy link
Collaborator Author

tswast commented Apr 9, 2025

e2e failure is FAILED tests/system/large/test_session.py::test_clean_up_via_context_manager[connect-method], which doesn't appear related to this change.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 9, 2025
@tswast tswast enabled auto-merge (squash) April 9, 2025 15:08
@tswast tswast merged commit 1ac0e1e into main Apr 9, 2025
19 of 24 checks passed
@tswast tswast deleted the b319116851-jellyfish branch April 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants