Skip to content

Conversation

sycai
Copy link
Contributor

@sycai sycai commented May 16, 2025

BEGIN_COMMIT_OVERRIDE
feat!: add structured output for ai map, ai filter and ai join (#1746)

The metric shows that there are no recent external calls to our ai operators, this change should be safe.

Also added:
logprob will be available as an output if the user wants to check them.

BREAKING CHANGE: the updated ai.map() parameter list is not backward-compatible
Release-As: 2.5.0
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 16, 2025
@sycai sycai requested a review from chelsea-lin May 17, 2025 00:01
@sycai sycai marked this pull request as ready for review May 17, 2025 00:01
@sycai sycai requested review from a team as code owners May 17, 2025 00:01
@chelsea-lin
Copy link
Contributor

The change only breaks pre-release features, so please add a Release-As: footer to the final commit message to make sure this does not trigger the 3.0 release.
See: https://github.com/googleapis/release-please/blob/main/README.md#how-do-i-change-the-version-number
For example: #1458

Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, with leaving two comments.

@@ -244,8 +301,8 @@ def test_map_multimodel(session, gemini_flash_model):
)
result = df.ai.map(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: assert the results' columns are expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would refrain from doing that because the answer is not stable.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sycai sycai enabled auto-merge (squash) May 19, 2025 18:52
@sycai sycai disabled auto-merge May 19, 2025 21:11
@sycai sycai enabled auto-merge (squash) May 19, 2025 21:13
@sycai sycai merged commit 133ac6b into main May 19, 2025
23 of 24 checks passed
@sycai sycai deleted the sycai_ai_ops branch May 19, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants