Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 16, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes internal issue 310260952 🦕

@shobsi shobsi requested review from a team as code owners November 16, 2023 05:59
@shobsi shobsi requested a review from Genesis929 November 16, 2023 05:59
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Nov 16, 2023
@shobsi shobsi requested a review from ashleyxuu November 17, 2023 23:57
Copy link
Contributor

@ashleyxuu ashleyxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Nov 20, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit c88d38e into main Nov 20, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-code-samples-index-columns branch November 20, 2023 23:02
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 20, 2023
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated
  - `DataFrame.columns`: https://screenshot.googleplex.com/3Bwdb482FBfEsi2
  - `DataFrame.index`: https://screenshot.googleplex.com/4iJymH3FxMn8Hhb
  - `Series.index`: https://screenshot.googleplex.com/7MXQcuASbQ3c8s5 

Fixes internal issue 310260952 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants