Skip to content

fix: make Series.str.replace work for simple strings #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: make Series.str.replace work for simple strings #285

merged 1 commit into from
Dec 21, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Dec 20, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 317269147 πŸ¦•

@shobsi shobsi requested review from a team as code owners December 20, 2023 22:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 20, 2023
@shobsi shobsi merged commit ad67465 into main Dec 21, 2023
@shobsi shobsi deleted the shobs-code-samples-str-dt branch December 21, 2023 00:33
@release-please release-please bot mentioned this pull request Dec 21, 2023
Merged
Genesis929 pushed a commit that referenced this pull request Dec 26, 2023
@shobsi @Genesis929
fix: make Series.str.replace work for simple strings (#285)
65de270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@stevewalker-de stevewalker-de Awaiting requested review from stevewalker-de stevewalker-de is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @TrevorBergeron