Skip to content

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 6, 2023

With this change BigFrames will not create a dataset upfront at the time of session creation, but instead leave it to the components which need the dataset to create it.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> πŸ¦•

With this change BigFrames will not create a dataset upfront at the time
of session creation, but instead leave it to the components which need the dataset to create it.
@shobsi shobsi requested review from a team as code owners October 6, 2023 23:48
@shobsi shobsi requested a review from TrevorBergeron October 6, 2023 23:48
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 6, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 11, 2023
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggested change.

@tswast tswast changed the title fix: Lazy creation of session dataset fix: create session dataset for remote functions only when needed Oct 11, 2023
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1d385be into main Oct 11, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the shobs-lazy-dataset-create branch October 11, 2023 20:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 12, 2023
πŸ€– I have created a release *beep* *boop*
---


## [0.8.0](https://togithub.com/googleapis/python-bigquery-dataframes/compare/v0.7.0...v0.8.0) (2023-10-12)


### ⚠ BREAKING CHANGES

* The default behavior of `to_parquet` is changing from no compression to `'snappy'` compression.

### Features

* Support compression in `to_parquet` ([a8c286f](https://togithub.com/googleapis/python-bigquery-dataframes/commit/a8c286f0995cc8cf2a4c44fb51855773ecf71f72))


### Bug Fixes

* Create session dataset for remote functions only when needed ([#94](https://togithub.com/googleapis/python-bigquery-dataframes/issues/94)) ([1d385be](https://togithub.com/googleapis/python-bigquery-dataframes/commit/1d385be1c68342a66ecb9f28c5efc83c18d0e64c))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants