Skip to content

Conversation

thejaredchapman
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 πŸ¦•

@thejaredchapman thejaredchapman requested a review from a team January 17, 2023 20:54
@thejaredchapman thejaredchapman requested review from a team as code owners January 17, 2023 20:54
@snippet-bot
Copy link

snippet-bot bot commented Jan 17, 2023 β€’

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 17, 2023
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a TODO to snippets.py (or wherever the old sample is) to remove it after updating cloud.google.com

@meredithslota
Copy link
Contributor

This is missing the CLA β€” we can either override this (see the CLA details) or close this and open a new PR, since the CLA violations were only in merging main into this branch.

@tswast
Copy link
Contributor

tswast commented Oct 5, 2023

This is missing the CLA β€” we can either override this (see the CLA details) or close this and open a new PR, since the CLA violations were only in merging main into this branch.

I'll rebase and force push to drop the bad merge commits.

@tswast tswast force-pushed the issue790-relax_column branch from 0276d5f to cbea873 Compare October 5, 2023 18:33
@tswast tswast requested a review from a team as a code owner October 5, 2023 18:33
@tswast tswast changed the title docs: Revised relax_column sample docs: revised relax column mode sample Oct 5, 2023
@tswast tswast enabled auto-merge (squash) October 5, 2023 18:34
@tswast tswast merged commit b8c9276 into main Oct 5, 2023
@tswast tswast deleted the issue790-relax_column branch October 5, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants