Skip to content

feat: support JSON type in insert_rows and as a scalar query parameter #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

feat: support JSON type in insert_rows and as a scalar query parameter #1757

merged 2 commits into from
Dec 19, 2023

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 15, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1756
πŸ¦•

@tswast tswast requested review from a team as code owners December 15, 2023 22:18
@tswast tswast requested a review from Linchin December 15, 2023 22:18
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 15, 2023
This was referenced Dec 15, 2023
Merged
Closed
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2023
chalmerlowe
chalmerlowe approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 02a7d12 into main Dec 19, 2023
@tswast tswast deleted the issue1756-json-insert_rows branch December 19, 2023 14:13
@release-please release-please bot mentioned this pull request Dec 18, 2023
Merged
@bricker bricker mentioned this pull request Jan 10, 2024
Closed
This was referenced Jan 17, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

@Linchin Linchin

@kiraksi kiraksi

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support JSON data type in insert_rows and as query parameters
5 participants
@tswast @chalmerlowe @Linchin @yoshi-kokoro @kiraksi