Skip to content

fix: use an allowlist instead of denylist to determine when query_and_wait uses jobs.query API #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: use an allowlist instead of denylist to determine when query_and_wait uses jobs.query API #1869

merged 1 commit into from
Mar 27, 2024

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 25, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1867 πŸ¦•

@tswast tswast requested review from a team as code owners March 25, 2024 15:17
@tswast tswast requested a review from mrfaizal March 25, 2024 15:17
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 25, 2024
@tswast tswast requested a review from chalmerlowe March 25, 2024 15:17
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 25, 2024
chalmerlowe
chalmerlowe approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit e265db6 into main Mar 27, 2024
@tswast tswast deleted the issue1867-query_and_wait-denylist branch March 27, 2024 14:58
@release-please release-please bot mentioned this pull request Mar 22, 2024
Merged
This was referenced Apr 2, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@mrfaizal mrfaizal Awaiting requested review from mrfaizal mrfaizal is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query_and_wait use in Cursor.execute breaks default_query_job_config in SQLAlchemy BQ Dialect
2 participants
@tswast @chalmerlowe