Various small cleanups#1267
Merged
Merged
Conversation
to facilitate development. also silence cmake version warning and change the C++ std to 17 as 14 does not support features like <optional>, which upsets clangd
'reason' isn't supported in our nightly but putting the reason on the same line as the allow makes the intent more obvious
this function just constructs an expression, and is confusingly named very similarly to compute_size_of_type
Contributor
Author
|
No semantic changes, and tests pass modulo the known Curl issue (#1245). |
kkysen
reviewed
Jul 5, 2025
| } | ||
|
|
||
| // None assignments don't prove enough type information unless there are follow-up assignments | ||
| // None assignments don't provide enough type information unless there are follow-up assignments |
Contributor
There was a problem hiding this comment.
Suggested change
| // None assignments don't provide enough type information unless there are follow-up assignments | |
| // `None` assignments don't provide enough type information unless there are follow-up assignments |
nit: A bit clearer since None could read as an English word, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1266 to keep it smaller, mostly intended to facilitate future development.