Support python 3.12 in test suite runner#1518
Conversation
The `Generator` class takes 3 type arguments, but in python 3.13 it became possible to just specify the first one and the other 2 would default to `None`. Explicitly adding the `None` arguments allows this to also work on python 3.12.
kkysen
left a comment
There was a problem hiding this comment.
Hmm, I guess this is fine, just annoying/ugly. I'd personally rather just upgrade Python (which is quite easy with uv), but this is okay, too, if that's preferable to others.
|
Yeah I agree it's uglier. Is the test suite setup with uv? idk how any of that works, but if it's easy enough to setup a venv or whatever with uv where I can locally setup 3.13 then I can also try that. |
|
I bumped us down to Python 3.12 over here immunant/c2rust-testsuite@593f753 after we discussed it on Slack. Please land with 3.12 support as Khyber approved rather spending more time on this matter. |
Yes.
If you increase the version in project.toml, go to that directory it's in, |
The
Generatorclass takes 3 type arguments, but in python 3.13 it became possible to just specify the first one and the other 2 would default toNone. Explicitly adding theNonearguments allows this to also work on python 3.12.One of my work machines is on a version of Ubuntu that has 3.12 installed and it looks like it'd be mildly painful to install 3.13. Seems like it'd be reasonable to support 3.12 here, unless there's some reason that'd be a bad idea.