refactor: configure cargo#1573
Merged
Merged
Conversation
kkysen
commented
Jan 27, 2026
Contributor
Author
kkysen
left a comment
There was a problem hiding this comment.
We might also be fetching the whole cargo registry in CI as well (I'm not sure if it's cached), so setting [unstable] sparse-registry = true in .cargo/config.toml might be useful for us as well, but I'll do that as a follow-up.
Without this, `cargo` never tries to load any of the settings from `.cargo/config.toml`, etc. For example, it doesn't load the `[unstable] sparse-registry = true` in `config.toml` set by crisp, which is what is causing the hang in `cargo refactor` in crisp.
2c0c785 to
338d60d
Compare
randomPoison
approved these changes
Jan 27, 2026
kkysen
added a commit
that referenced
this pull request
Feb 11, 2026
So #1573 didn't catch all of the `cargo` invocations that `c2rust-refactor` is doing. This does (I checked all of the places where `cargo::Config` is created), so it should finally fix GaloisInc/Tractor-Crisp#55 for good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this,
cargonever tries to load any of the settings from.cargo/config.toml, etc. For example, it doesn't load the[unstable] sparse-registry = trueinconfig.tomlset by crisp, which is what is causing the hang incargo refactorin crisp.