[IMP] openupgrade: strip_view_arch_attrs() helper for RNG-removed attrs

[dnplkndll]

Common shape across major Odoo migrations: a RelaxNG schema tightens between versions, attributes valid in N become invalid in N+1, and stored arch_db blobs that still carry them fail view validation when the module is upgraded — leaving the view unrenderable and breaking downstream xml_id lookups.

This helper does the SQL-side pre-migration scrub, scoped by view type, with (element_regex, attr_regex) pattern pairs. Multi-lang jsonb arch_db (17.0+) handled via jsonb_each + jsonb_object_agg.

Signature

strip_view_arch_attrs(cr, view_type, attr_patterns, like_hints=None)

• view_type: 'search', 'form', etc. Strict type-scoping is intentional — RNG removals are type-specific. e.g. <list expand=...> remained valid in 19.0 even though <group expand=...> was removed; broader stripping would brick the list views.
• attr_patterns: iterable of (element_regex, attr_regex) POSIX regex pairs. Strips <{element_regex}[^>]*?\s+{attr_regex} occurrences, preserving the rest of the element tag.
• like_hints: optional substring filter to skip views that clearly carry none of the patterns (cheap pre-filter).

First consumer

OpenUpgrade base/19.0.1.3/pre-migration.py strips <group expand=...>, <field expand=...> (searchpanel), and <group string="Group By"> from <search> views, which the 19.0 RNG schema rejects:

openupgrade.strip_view_arch_attrs(env.cr, "search", [
    ("(?:group|field)", 'expand="[^"]*"'),
    ("group", 'string="Group By"'),
], like_hints=["expand=", 'string="Group By"'])

Validated on a Tier-1 600-module Odoo seed: 181 affected views → 0 post-migration, sub-second wall-clock.

Notes

• Pre-17.0 arch_db is text not jsonb; helper raises rather than silently using the wrong code path.
• Each pattern runs as a separate nested regexp_replace; not combined into a single alternation for clarity.
• Backreference \1 preserves any other attrs on the same element tag.