Fix missing tree_reduce import in models/cache.py#1165
Merged
angeloskath merged 1 commit intoApr 20, 2026
Conversation
_BaseCache.nbytes calls tree_reduce but the module only imported tree_flatten, tree_map, tree_unflatten from mlx.utils. Reading .nbytes on any cache that inherits the base implementation (hit by MoE architectures like Qwen3.5 MoE) raised NameError: name 'tree_reduce' is not defined. Fixes ml-explore#1164.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_BaseCache.nbytescallstree_reduce, but the module only importstree_flatten,tree_map,tree_unflattenfrommlx.utils. Reading.nbyteson any cache that inherits the base implementation (hit by MoE architectures like Qwen3.5 MoE) raisesNameError: name 'tree_reduce' is not defined.Fixes #1164.
Diff
Repro (before the fix)
After the patch, the same request returns a normal completion. Verified on LM Studio 0.4.12+1 with bundled mlx-lm 0.31.3 on macOS Apple Silicon.