Skip to content

Commit 00cb759

Browse files
committed
remove MySQL folder mount
- suspecting that we're not supposed to mount the MySQL folder in the CodeSpaces environment. It looks like our MySQL fails to start for some reason. That's why the 'mysql_service' name does not DNS-resolve unlike 'php' or 'nginx' Let's try - also, port 3306 does not need to be exposed in devcontainer.json, unless we try to access it from the outside.
1 parent f515d9a commit 00cb759

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
}
4242
},
4343

44-
"forwardPorts": [80,3306],
44+
"forwardPorts": [80],
4545

4646
// execute our one-time repo init if /vendor/ does not exist
4747
"postCreateCommand": "sh init_repo.sh"

.devcontainer/docker-compose.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,20 @@ services:
5858
# the two variales below don't seem to be used at all. Commenting out for now
5959
#MYSQL_USER: myuser
6060
#MYSQL_PASSWORD: mypassword
61-
volumes:
61+
#volumes:
6262
# map local /data/ folder to container /var/lib/mysql for MySQL data persistence
63-
- ${MYSQL_DATA_HOST_PATH}:${MYSQL_DATA_CONTAINER_PATH}
63+
# - ${MYSQL_DATA_HOST_PATH}:${MYSQL_DATA_CONTAINER_PATH}
6464
ports:
6565
- "3306:3306"
6666
# host_port:container_port
6767

6868

69-
redis:
70-
image: redis:latest
71-
ports:
72-
- "6379:6379"
73-
volumes:
74-
- ${REDIS_DATA_HOST_PATH}:${REDIS_DATA_CONTAINER_PATH}
69+
# redis:
70+
# image: redis:latest
71+
# ports:
72+
# - "6379:6379"
73+
# volumes:
74+
# - ${REDIS_DATA_HOST_PATH}:${REDIS_DATA_CONTAINER_PATH}
7575

7676
# Notes:
7777
#

0 commit comments

Comments
 (0)