Skip to content

Improve plugin source modeling and runtime dedup#414

Merged
gschier merged 7 commits into
mountain-loop:mainfrom
gschier:plugin-source-runtime-dedup
Mar 2, 2026
Merged

Improve plugin source modeling and runtime dedup#414
gschier merged 7 commits into
mountain-loop:mainfrom
gschier:plugin-source-runtime-dedup

Conversation

@gschier
Copy link
Copy Markdown
Member

@gschier gschier commented Mar 2, 2026

Summary

  • add plugins.source migration/backfill and enforce unique plugins.directory
  • model plugin source as a typed PluginSource enum and expose it in TS bindings
  • make plugin upserts directory-aware by reusing existing plugin id for matching directory
  • set explicit source on bundled/filesystem/registry plugin write paths
  • dedupe runtime plugin loading by metadata name with precedence filesystem > registry > bundled
  • filter registry update checks by source == registry
  • update settings plugin tabs to use plugin.source instead of directory heuristics
  • return resolved plugin set from models_workspace_models so frontend counts match loaded plugins

Validation

  • cargo check -p yaak-models -p yaak-plugins -p yaak-cli
  • cargo check --manifest-path crates-tauri/yaak-app/Cargo.toml
  • npm run lint (existing repo warnings only)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44e576001f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates-tauri/yaak-app/src/lib.rs Outdated
@gschier
Copy link
Copy Markdown
Member Author

gschier commented Mar 2, 2026

@codex review

@gschier gschier merged commit 2ca5112 into mountain-loop:main Mar 2, 2026
1 check passed
@gschier gschier deleted the plugin-source-runtime-dedup branch March 2, 2026 00:31
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6f2e48434

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates-tauri/yaak-app/src/lib.rs
hezhizhen pushed a commit to hezhizhen/yaak that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant