Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nhairs/python-json-logger
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.10
Choose a base ref
...
head repository: nhairs/python-json-logger
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.11
Choose a head ref
  • 6 commits
  • 5 files changed
  • 4 contributors

Commits on Mar 5, 2019

  1. Consistent control of caller stack frames output

    This commit aims to achieve consistent stack frames control
    by `stack_info` flag in logging calls the same as that in python
    logging module.
    Currently, both a field named `stack_info` for JsonFormatter
    and `stack_info=True` for logging function are needed for
    stack frames to be properly displayed.
    If `stack_info` field name is not passed, no output is given
    irrespective of the `stack_info` flag in logging calls.
    If `stack_info=False` in logging calls and `stack_info` is also
    passed as one field for JsonFormatter, the output is `{"stack_info": null}`.
    Above behavior is not very consistent and requires two controls
    to output stack frames. This commit makes 'stack_info' flag in logging calls
    as single point control of stack frames output and there is no need to
    pass `stack_info` field into JsonFormatter.
    ghShu committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    c15337a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. Configuration menu
    Copy the full SHA
    88838bd View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. Merge pull request #72 from ghShu/feature/ghshu/stack_info

    Consistent control of stack_info
    madzak authored Mar 29, 2019
    Configuration menu
    Copy the full SHA
    3a9a936 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #75 from FlyrInc/feature/support-py3.7

    feat: add support for Python 3.7
    madzak authored Mar 29, 2019
    Configuration menu
    Copy the full SHA
    32aa512 View commit details
    Browse the repository at this point in the history
  3. Only process stack_info if we are in python3+

    Zakaria Zajac committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    46826c4 View commit details
    Browse the repository at this point in the history
  4. Update README.markdown

    Added python2.7 EOL notice.
    madzak authored Mar 29, 2019
    Configuration menu
    Copy the full SHA
    687cc52 View commit details
    Browse the repository at this point in the history
Loading