Skip to content

fix fetch support for node < 18.14.0#3124

Closed
KhafraDev wants to merge 1 commit into
nodejs:mainfrom
KhafraDev:node-18-13
Closed

fix fetch support for node < 18.14.0#3124
KhafraDev wants to merge 1 commit into
nodejs:mainfrom
KhafraDev:node-18-13

Conversation

@KhafraDev
Copy link
Copy Markdown
Member

Fixes #3123

I'm wondering if we should drop support for node < v18.17.0. The person who reported it mentioned that we can't run the test suite, so there's no way to guarantee that old v18 versions stay supported.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2024

Codecov Report

❌ Patch coverage is 39.53488% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.09%. Comparing base (f979ec3) to head (15bdaa6).
⚠️ Report is 1000 commits behind head on main.

Files with missing lines Patch % Lines
lib/web/fetch/index.js 38.09% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
- Coverage   94.18%   94.09%   -0.10%     
==========================================
  Files          89       89              
  Lines       24379    24418      +39     
==========================================
+ Hits        22962    22975      +13     
- Misses       1417     1443      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KhafraDev KhafraDev marked this pull request as draft April 15, 2024 19:14
@KhafraDev
Copy link
Copy Markdown
Member Author

I'm making an alternative to this PR to drop node support for < v18.17.0

@KhafraDev KhafraDev marked this pull request as ready for review April 15, 2024 19:40
@KhafraDev
Copy link
Copy Markdown
Member Author

#3125 is a better solution IMO, also lets us drop the entire custom File implementation.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we can test it, it doesn't exists. We should just drop everything under v18.17.0

@KhafraDev KhafraDev closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

undici.fetch breaks on Node.js <=18.13.0 in undici@6.13.0

4 participants