Skip to content

Commit cc0dda6

Browse files
Andy FanCommitfest Bot
authored andcommitted
Remove HeapTupleheaderSetXminCommitted/Invalid functions
Reasons include: (1). They are not used in core or any known third-party extension in codesearch.debian.net. (2). They are not safe to use when comparing with HeapTupleSetHintBits which is a public API as well for third party. (3). These functions do has some maintenance cost when people try to understanding them, including identifying they are not used at all and the right one is SetHintBits. Discussion: https://www.postgresql.org/message-id/87frfmgigm.fsf%40163.com
1 parent 5761d99 commit cc0dda6

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

src/include/access/htup_details.h

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -357,20 +357,6 @@ HeapTupleHeaderXminFrozen(const HeapTupleHeaderData *tup)
357357
return (tup->t_infomask & HEAP_XMIN_FROZEN) == HEAP_XMIN_FROZEN;
358358
}
359359

360-
static inline void
361-
HeapTupleHeaderSetXminCommitted(HeapTupleHeaderData *tup)
362-
{
363-
Assert(!HeapTupleHeaderXminInvalid(tup));
364-
tup->t_infomask |= HEAP_XMIN_COMMITTED;
365-
}
366-
367-
static inline void
368-
HeapTupleHeaderSetXminInvalid(HeapTupleHeaderData *tup)
369-
{
370-
Assert(!HeapTupleHeaderXminCommitted(tup));
371-
tup->t_infomask |= HEAP_XMIN_INVALID;
372-
}
373-
374360
static inline void
375361
HeapTupleHeaderSetXminFrozen(HeapTupleHeaderData *tup)
376362
{

0 commit comments

Comments
 (0)