Skip to content

refactor(web): update to typescript, cleanup small bugs + workspace#244

Merged
prayag17 merged 15 commits into
prayag17:mainfrom
dan-online:main
Jan 11, 2024
Merged

refactor(web): update to typescript, cleanup small bugs + workspace#244
prayag17 merged 15 commits into
prayag17:mainfrom
dan-online:main

Conversation

@dan-online
Copy link
Copy Markdown
Contributor

@dan-online dan-online commented Jan 8, 2024

I've decided to do some housekeeping with this project for no reason other than I was bored, here's my plan:

  • Update main parts of codebase to TypeScript
  • Cleanup workspace (add biomejs, commit standards etc)
  • CI/CD
  • Fix small bugs
    • Change Server choice relaunch to redirect
    • Fix redirect issues
  • Refactor main code

@dan-online dan-online marked this pull request as draft January 8, 2024 16:22
@elendil7
Copy link
Copy Markdown

elendil7 commented Jan 8, 2024

Dan codes strikes again 🦬🐥🐗

@prayag17
Copy link
Copy Markdown
Owner

prayag17 commented Jan 9, 2024

Don't change the tauri store to localStorage since I do plan on adding default values to the store for settings.
I don't plan on refactoring the entire codebase to typescript YET since I don't understand it fully.
I did plan on adding user credentials encryption by using https://github.com/tauri-apps/tauri-plugin-stronghold, you can do it if you want to

Thanks for your contribution.

@dan-online
Copy link
Copy Markdown
Contributor Author

Don't change the tauri store to localStorage since I do plan on adding default values to the store for settings.
I don't plan on refactoring the entire codebase to typescript YET since I don't understand it fully.
I did plan on adding user credentials encryption by using https://github.com/tauri-apps/tauri-plugin-stronghold, you can do it if you want to

Thanks for your contribution.

I don't plan on completely removing Tauri store, just checking if it's available, and if so using it, so it can run stand alone in-browser otherwise. I do think I'll also checkout changing it to something like Redux? if that's something you're interested in. As for typescript that's completely fine, I've only updated the first few main files and the store which caught a lot of future bugs, I can leave it like that for now if you'd like.

@dan-online dan-online marked this pull request as ready for review January 9, 2024 16:53
Copy link
Copy Markdown
Owner

@prayag17 prayag17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution :).

@prayag17 prayag17 merged commit b6445e2 into prayag17:main Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants