Skip to content

fix: legacy_packaging fix #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryiii merged 3 commits into from
Jan 12, 2026
+7 −3
Merged

fix: legacy_packaging fix #1048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2035640
fix: legacy_packaging fix
henryiii Jan 12, 2026
f8b42b4
Update src/packaging/version.py
henryiii Jan 12, 2026
0188fe9
fix: legacy_packaging fix - try two
henryiii Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/packaging/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,13 @@ class InvalidVersion(ValueError):
class _BaseVersion:
__slots__ = ()

@property
def _key(self) -> tuple[Any, ...]:
raise NotImplementedError # pragma: no cover
# This can also be a normal member (see the packaging_legacy package);
# we are just requiring it to be readable. Actually defining a property
# has runtime effect on subclasses, so it's typing only.
if typing.TYPE_CHECKING:

@property
def _key(self) -> tuple[Any, ...]: ...

def __hash__(self) -> int:
return hash(self._key)
Expand Down
Loading