ENH, MAINT: Bring KDTree interface to feature-parity with cKDTree #12852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Nov 9, 2020
There was a problem hiding this comment.
Looks like a pretty straightforward extension, +1 for merge for 1.6.0.
@sturlamolden did you want to look?
3517711 to
b10dbf8
Compare
rgommers
approved these changes
Nov 15, 2020
There was a problem hiding this comment.
LGTM too. Fixed one merge conflict with test fixtures, CI failures are unrelated - merging. Thanks @peterbell10!
|
Release note was already present, so all good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Ref gh-8923
What does this implement/fix?
This expands the
KDTreeinterface to expose all of thecKDTreefunctionality. I've also merged the two classes documentation together so they're almost identical, except fordeprecationandversionaddedmessages.Most of the tests are now parametrized on the tree type as well, so the exact same tests are run for
KDTreeandcKDTreewith minimal code duplication. This is done through pytest fixtures for functional tests and with a special class decorator for class-style tests.