fix: Use GITHUB_TOKEN for release-please and enable npm provenance#925
Merged
Conversation
…publish Co-authored-by: broofa <164050+broofa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix trusted publishing misconfiguration with PAT secret
fix: Use GITHUB_TOKEN for release-please and enable npm provenance
Feb 25, 2026
Member
|
@Cevan00: Can you confirm these changes make sense based on your experience? |
|
Hi @broofa , Yes this looks accurate. I appreciate your attention to the matter! |
broofa
approved these changes
Feb 26, 2026
broofa
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow was using a PAT (
UUID_RELEASE_PLEASE_TOKEN) forrelease-please-action, which doesn't work with npm trusted publishing. The workflow also lacked the--provenanceflag needed to generate signed attestations via OIDC — the missing piece for the npm Provenance badge.Changes
.github/workflows/release-please.ymlsecrets.GITHUB_TOKENforrelease-please-action(its intended default)--provenanceflag tonpm publish, enabling OIDC-based attestation via the existingid-token: writepermissionNo npm access token is required — the
id-token: writepermission (already present) supplies the OIDC token that npm uses to verify and record provenance.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.