[Python-Dev] building a module catalogue with buildbot

Brian Warner warner at lothar.com
Thu Jan 12 01:04:27 CET 2006


> PS If there was a method on ShellCommand, adding a step would be simpler,
> e.g.,
>
>   def addStep(self, cls, **kwds):
>     self.steps.append((cls, kwds))

Ooh! I like that.

> then we could do: f.addStep(Catalog, command=Catalog.command)

It would be even simpler: f.addStep(Catalog). The command= argument is
provided by the class-level attributes of your Catalog class (it can be set
by either an attribute or by a constructor argument, but if it's always going
to be the same thing then the attribute is easier).

If you make a patch for this, I'll commit it. If not, I'll write one before I
get the next release out.

thanks,
 -Brian


More information about the Python-Dev mailing list